Re: [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-26 Thread Lukasz Majewski
On Wed, 26 Jun 2013 16:38:15 +0530, Viresh Kumar wrote: > On 26 June 2013 16:34, Lukasz Majewski wrote: > > err_out_kobj_put: > > list_del(&cpufreq_policy_list); > > [rest of error path] > > I couldn't find err_out_kobj_put in existing code :) > > BTW, just add to the list only

Re: [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-26 Thread Viresh Kumar
On 26 June 2013 16:34, Lukasz Majewski wrote: > err_out_kobj_put: > list_del(&cpufreq_policy_list); > [rest of error path] I couldn't find err_out_kobj_put in existing code :) BTW, just add to the list only once everything passed. -- To unsubscribe from this list: send the line "

Re: [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-26 Thread Lukasz Majewski
On Wed, 26 Jun 2013 16:26:30 +0530, Viresh Kumar wrote: > On 26 June 2013 16:24, Lukasz Majewski wrote: > >> > --- > > > > So here <---> I will put change log for v5. > > correct. OK. > > >> > ret = cpufreq_add_dev_interface(cpu, policy, dev); > >> > if (ret) > > > > I will add

Re: [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-26 Thread Viresh Kumar
On 26 June 2013 16:24, Lukasz Majewski wrote: >> > --- > > So here <---> I will put change log for v5. correct. >> > ret = cpufreq_add_dev_interface(cpu, policy, dev); >> > if (ret) > > I will add list_del(&cpufreq_policy_list); > here. May not be sufficient. You must do it once

Re: [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-26 Thread Lukasz Majewski
On 26 Jun 2013 16:05:12,Viresh Kumar wrote: > On 19 June 2013 22:42, Lukasz Majewski wrote: > > Policies available in a cpufreq framework are now linked together. > > They are accessible via cpufreq_policy_list defined at cpufreq core. > > > > Signed-off-by: Lukasz Majewski > > Signed-off-by: My

Re: [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-26 Thread Viresh Kumar
On 19 June 2013 22:42, Lukasz Majewski wrote: > Policies available in a cpufreq framework are now linked together. They are > accessible via cpufreq_policy_list defined at cpufreq core. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Myungjoo Ham > > Changes for v4: > - New patch You need t

[PATCH v4 1/7] cpufreq: Store cpufreq policies in a list

2013-06-19 Thread Lukasz Majewski
Policies available in a cpufreq framework are now linked together. They are accessible via cpufreq_policy_list defined at cpufreq core. Signed-off-by: Lukasz Majewski Signed-off-by: Myungjoo Ham Changes for v4: - New patch --- drivers/cpufreq/cpufreq.c |3 +++ include/linux/cpufreq.h |