Re: [PATCH v4 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

Hello Nikita! Overall looks good to me, except one missing "static" qialifier below... On Fri, 2021-02-05 at 11:05 +0300, Nikita Shubin wrote: > Two index spaces and ep93xx_gpio_port conversion are confusing. > > Instead add a separate struct to store necessary data and remove >

[PATCH v4 1/7] gpio: gpio-ep93xx: fix BUG_ON port F usage

Two index spaces and ep93xx_gpio_port conversion are confusing. Instead add a separate struct to store necessary data and remove ep93xx_gpio_port. - add struct to store IRQ related data for each IRQ capable chip - replace offset array with defined offsets - add IRQ registers offset for each IRQ