Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 12:36 PM, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn > Reviewed-by: Max Gurtovoy > --- > include/linux/nvme.h | 19 +++ > 1 file changed, 19 insertions(+) > Reviewed-by: Hannes Reinecke

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 12:36 PM, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn > Reviewed-by: Max Gurtovoy > --- > include/linux/nvme.h | 19 +++ > 1 file changed, 19 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Christoph Hellwig
On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote: >> +struct nvme_ns_identifier_hdr { >> +__u8 nidt; >> +__u8 nidl; >> +__le16 reserved; >> +}; > > Nit: _hdr is usually associated with a message or alike. > > Maybe nvme_ns_id_desc is more consistent with the spec

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Christoph Hellwig
On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote: >> +struct nvme_ns_identifier_hdr { >> +__u8 nidt; >> +__u8 nidl; >> +__le16 reserved; >> +}; > > Nit: _hdr is usually associated with a message or alike. > > Maybe nvme_ns_id_desc is more consistent with the spec

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Sagi Grimberg
On 04/06/17 13:36, Johannes Thumshirn wrote: Signed-off-by: Johannes Thumshirn Reviewed-by: Max Gurtovoy --- include/linux/nvme.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/nvme.h b/include/linux/nvme.h

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Sagi Grimberg
On 04/06/17 13:36, Johannes Thumshirn wrote: Signed-off-by: Johannes Thumshirn Reviewed-by: Max Gurtovoy --- include/linux/nvme.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index b625bacf37ef..afa6ef484e50 100644

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Sagi Grimberg
Looks good Johannes, Reviewed-by: Sagi Grimberg

Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Sagi Grimberg
Looks good Johannes, Reviewed-by: Sagi Grimberg

[PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Johannes Thumshirn
Signed-off-by: Johannes Thumshirn Reviewed-by: Max Gurtovoy --- include/linux/nvme.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index b625bacf37ef..afa6ef484e50 100644 ---

[PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures

2017-06-04 Thread Johannes Thumshirn
Signed-off-by: Johannes Thumshirn Reviewed-by: Max Gurtovoy --- include/linux/nvme.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index b625bacf37ef..afa6ef484e50 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h