Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-13 Thread Martijn Coenen
On Wed, May 13, 2020 at 12:22 PM Christoph Hellwig wrote: > > On Wed, May 13, 2020 at 09:07:43AM +0200, Martijn Coenen wrote: > > On Wed, May 13, 2020 at 4:30 AM Jens Axboe wrote: > > > > Looks acceptable to me, but I'm getting a failure applying it to > > > > for-5.8/drivers on this patch: > >

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 09:07:43AM +0200, Martijn Coenen wrote: > On Wed, May 13, 2020 at 4:30 AM Jens Axboe wrote: > > > Looks acceptable to me, but I'm getting a failure applying it to > > > for-5.8/drivers on this patch: > > > > > > Applying: loop: Refactor loop_set_status() size calculation >

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-13 Thread Martijn Coenen
On Wed, May 13, 2020 at 4:30 AM Jens Axboe wrote: > > Looks acceptable to me, but I'm getting a failure applying it to > > for-5.8/drivers on this patch: > > > > Applying: loop: Refactor loop_set_status() size calculation > > > > So you'll probably want to respin on the right branch. This series

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-12 Thread Jens Axboe
On 5/12/20 8:29 PM, Jens Axboe wrote: > On 5/12/20 12:46 AM, Martijn Coenen wrote: >> Hi Jens, >> >> What do you think of this series? > > Looks acceptable to me, but I'm getting a failure applying it to > for-5.8/drivers on this patch: > > Applying: loop: Refactor loop_set_status() size

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-12 Thread Jens Axboe
On 5/12/20 12:46 AM, Martijn Coenen wrote: > Hi Jens, > > What do you think of this series? Looks acceptable to me, but I'm getting a failure applying it to for-5.8/drivers on this patch: Applying: loop: Refactor loop_set_status() size calculation So you'll probably want to respin on the right

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-12 Thread Martijn Coenen
Hi Jens, What do you think of this series? Thanks, Martijn On Wed, Apr 29, 2020 at 4:03 PM Martijn Coenen wrote: > > This allows userspace to completely setup a loop device with a single > ioctl, removing the in-between state where the device can be partially > configured - eg the loop device

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-06 Thread Martijn Coenen
On Wed, May 6, 2020 at 11:44 AM Michael Kerrisk (man-pages) > > Can we have also a patch for the loop.4 manual page please? Ack, will do when the series lands. Best, Martijn > > Thanks, > > Michael > > > -- > Michael Kerrisk > Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ >

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-06 Thread Martijn Coenen
On Wed, May 6, 2020 at 8:09 AM Christoph Hellwig wrote: > > Thanks, this looks very nice! Thanks! And thanks for all the feedback, it has made this series a lot cleaner. > > Reviewed-by: Christoph Hellwig > > Are you also going to submit a patch to util-linux to use the new > ioctl? Yeah, I'm

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-06 Thread Michael Kerrisk (man-pages)
Hi Martijn, On 4/29/20 4:03 PM, Martijn Coenen wrote: > This allows userspace to completely setup a loop device with a single > ioctl, removing the in-between state where the device can be partially > configured - eg the loop device has a backing file associated with it, > but is reading from the

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-06 Thread Christoph Hellwig
Thanks, this looks very nice! Reviewed-by: Christoph Hellwig Are you also going to submit a patch to util-linux to use the new ioctl?

[PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-04-29 Thread Martijn Coenen
This allows userspace to completely setup a loop device with a single ioctl, removing the in-between state where the device can be partially configured - eg the loop device has a backing file associated with it, but is reading from the wrong offset. Besides removing the intermediate state,