Re: [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-14 Thread Tomeu Vizoso
On 12 November 2014 16:45, Thierry Reding wrote: > On Wed, Nov 12, 2014 at 08:56:33AM +0100, Tomeu Vizoso wrote: >> +struct emc_timing { >> + unsigned long rate; >> + >> + /* >> + * Store EMC burst data in a union to minimize mistakes. This allows >> + * us to use the same

Re: [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-14 Thread Tomeu Vizoso
On 12 November 2014 16:45, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Nov 12, 2014 at 08:56:33AM +0100, Tomeu Vizoso wrote: snip +struct emc_timing { + unsigned long rate; + + /* + * Store EMC burst data in a union to minimize mistakes. This allows + * us to

Re: [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-12 Thread Mikko Perttunen
On 11/12/2014 05:45 PM, Thierry Reding wrote: On Wed, Nov 12, 2014 at 08:56:33AM +0100, Tomeu Vizoso wrote: [...] diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c [...] +static int t124_emc_burst_regs[] = { The t124 prefix seems rather redundant in a

Re: [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-12 Thread Thierry Reding
On Wed, Nov 12, 2014 at 08:56:33AM +0100, Tomeu Vizoso wrote: [...] > diff --git a/drivers/memory/tegra/tegra124-emc.c > b/drivers/memory/tegra/tegra124-emc.c [...] > +static int t124_emc_burst_regs[] = { The t124 prefix seems rather redundant in a Tegra124-specific file. Also these should

[PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-12 Thread Tomeu Vizoso
From: Mikko Perttunen Implements functionality needed to change the rate of the memory bus clock. Signed-off-by: Mikko Perttunen Signed-off-by: Tomeu Vizoso --- v4: * Move CONFIG to drivers/memory/tegra/Kconfig * Adapt to changes in the OF bindings * Fix comment style

[PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-12 Thread Tomeu Vizoso
From: Mikko Perttunen mperttu...@nvidia.com Implements functionality needed to change the rate of the memory bus clock. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com Signed-off-by: Tomeu Vizoso tomeu.viz...@collabora.com --- v4: * Move CONFIG to drivers/memory/tegra/Kconfig

Re: [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-12 Thread Thierry Reding
On Wed, Nov 12, 2014 at 08:56:33AM +0100, Tomeu Vizoso wrote: [...] diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c [...] +static int t124_emc_burst_regs[] = { The t124 prefix seems rather redundant in a Tegra124-specific file. Also these should really

Re: [PATCH v4 10/13] memory: tegra: Add EMC (external memory controller) driver

2014-11-12 Thread Mikko Perttunen
On 11/12/2014 05:45 PM, Thierry Reding wrote: On Wed, Nov 12, 2014 at 08:56:33AM +0100, Tomeu Vizoso wrote: [...] diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c [...] +static int t124_emc_burst_regs[] = { The t124 prefix seems rather redundant in a