Re: Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-30 Thread Sameer Pujar
On 6/30/2020 4:25 PM, Mark Brown wrote: On Tue, Jun 30, 2020 at 09:53:13AM +0530, Sameer Pujar wrote: On 6/30/2020 7:38 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments + if (cpu != codec) + of_property_read_u32(codec, prop, &props->mclk_

Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-30 Thread Mark Brown
On Tue, Jun 30, 2020 at 09:53:13AM +0530, Sameer Pujar wrote: > On 6/30/2020 7:38 AM, Kuninori Morimoto wrote: > > External email: Use caution opening links or attachments > > > > > + if (cpu != codec) > > > > > + of_property_read_u32(codec, prop, &props->mclk_fs); > Sorry if I wa

Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-29 Thread Sameer Pujar
On 6/30/2020 7:38 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi Sameer snprintf(prop, sizeof(prop), "%smclk-fs", prefix); of_property_read_u32(node, prop, &props->mclk_fs); of_property_read_u32(cpu, prop, &props-

Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-29 Thread Kuninori Morimoto
Hi Sameer > >>snprintf(prop, sizeof(prop), "%smclk-fs", prefix); > >>of_property_read_u32(node, prop, &props->mclk_fs); > >>of_property_read_u32(cpu, prop, &props->mclk_fs); > >> - of_property_read_u32(codec, prop, &props->mclk_fs); > >> + > >> + if

Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-29 Thread Sameer Pujar
On 6/29/2020 6:35 AM, Kuninori Morimoto wrote: External email: Use caution opening links or attachments Hi Sameer CPU/Codec in DPCM DAI links are connected as CPU<->Dummy and Dummy<->Codec. Though mostly CPU won't use/require 'mclk-fs' property, looping over 'np' (current child node in a D

Re: [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-28 Thread Kuninori Morimoto
Hi Sameer > CPU/Codec in DPCM DAI links are connected as CPU<->Dummy and Dummy<->Codec. > Though mostly CPU won't use/require 'mclk-fs' property, looping over > 'np' (current child node in a DAI link) can help in cases where multiple > Codecs are defined. This further helps to get rid of 'codec'

[PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs'

2020-06-26 Thread Sameer Pujar
CPU/Codec in DPCM DAI links are connected as CPU<->Dummy and Dummy<->Codec. Though mostly CPU won't use/require 'mclk-fs' property, looping over 'np' (current child node in a DAI link) can help in cases where multiple Codecs are defined. This further helps to get rid of 'codec' argument from simple