Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-19 Thread Dmitry Osipenko
19.07.2019 4:22, Chanwoo Choi пишет: > On 19. 7. 19. 오전 10:13, Dmitry Osipenko wrote: >> В Thu, 18 Jul 2019 18:07:05 +0900 >> Chanwoo Choi пишет: >> >>> On 19. 7. 18. 오전 12:46, Dmitry Osipenko wrote: 17.07.2019 9:45, Chanwoo Choi пишет: > On 19. 7. 16. 오후 10:26, Dmitry Osipenko wrote:

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-18 Thread Chanwoo Choi
On 19. 7. 19. 오전 10:13, Dmitry Osipenko wrote: > В Thu, 18 Jul 2019 18:07:05 +0900 > Chanwoo Choi пишет: > >> On 19. 7. 18. 오전 12:46, Dmitry Osipenko wrote: >>> 17.07.2019 9:45, Chanwoo Choi пишет: On 19. 7. 16. 오후 10:26, Dmitry Osipenko wrote: > 16.07.2019 15:23, Chanwoo Choi

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-18 Thread Dmitry Osipenko
В Thu, 18 Jul 2019 18:07:05 +0900 Chanwoo Choi пишет: > On 19. 7. 18. 오전 12:46, Dmitry Osipenko wrote: > > 17.07.2019 9:45, Chanwoo Choi пишет: > >> On 19. 7. 16. 오후 10:26, Dmitry Osipenko wrote: > >>> 16.07.2019 15:23, Chanwoo Choi пишет: > Hi Dmitry, > > Usually, the

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-18 Thread Chanwoo Choi
On 19. 7. 18. 오전 12:46, Dmitry Osipenko wrote: > 17.07.2019 9:45, Chanwoo Choi пишет: >> On 19. 7. 16. 오후 10:26, Dmitry Osipenko wrote: >>> 16.07.2019 15:23, Chanwoo Choi пишет: Hi Dmitry, Usually, the kernel log print for all users such as changing the frequency, fail or

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-17 Thread Dmitry Osipenko
17.07.2019 9:45, Chanwoo Choi пишет: > On 19. 7. 16. 오후 10:26, Dmitry Osipenko wrote: >> 16.07.2019 15:23, Chanwoo Choi пишет: >>> Hi Dmitry, >>> >>> Usually, the kernel log print for all users >>> such as changing the frequency, fail or success. >>> >>> But, if the log just show the register

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-17 Thread Chanwoo Choi
On 19. 7. 16. 오후 10:26, Dmitry Osipenko wrote: > 16.07.2019 15:23, Chanwoo Choi пишет: >> Hi Dmitry, >> >> Usually, the kernel log print for all users >> such as changing the frequency, fail or success. >> >> But, if the log just show the register dump, >> it is not useful for all users. It is

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-16 Thread Dmitry Osipenko
16.07.2019 15:23, Chanwoo Choi пишет: > Hi Dmitry, > > Usually, the kernel log print for all users > such as changing the frequency, fail or success. > > But, if the log just show the register dump, > it is not useful for all users. It is just used > for only specific developer. > > I recommend

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, Usually, the kernel log print for all users such as changing the frequency, fail or success. But, if the log just show the register dump, it is not useful for all users. It is just used for only specific developer. I recommend that you better to add more exception handling code on

[PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-07 Thread Dmitry Osipenko
Add debug messages to know about what's happening in hardware and how driver reacts. Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra30-devfreq.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/devfreq/tegra30-devfreq.c