Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-19 Thread Dmitry Osipenko
19.07.2019 9:01, Chanwoo Choi пишет: > On 19. 7. 19. 오전 11:14, Dmitry Osipenko wrote: >> В Fri, 19 Jul 2019 10:27:16 +0900 >> Chanwoo Choi пишет: >> >>> On 19. 7. 19. 오전 10:24, Chanwoo Choi wrote: On 19. 7. 19. 오전 10:22, Dmitry Osipenko wrote: > В Thu, 18 Jul 2019 18:09:05 +0900 >

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-18 Thread Chanwoo Choi
On 19. 7. 19. 오전 11:14, Dmitry Osipenko wrote: > В Fri, 19 Jul 2019 10:27:16 +0900 > Chanwoo Choi пишет: > >> On 19. 7. 19. 오전 10:24, Chanwoo Choi wrote: >>> On 19. 7. 19. 오전 10:22, Dmitry Osipenko wrote: В Thu, 18 Jul 2019 18:09:05 +0900 Chanwoo Choi пишет: > On 19. 7.

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-18 Thread Dmitry Osipenko
В Fri, 19 Jul 2019 10:27:16 +0900 Chanwoo Choi пишет: > On 19. 7. 19. 오전 10:24, Chanwoo Choi wrote: > > On 19. 7. 19. 오전 10:22, Dmitry Osipenko wrote: > >> В Thu, 18 Jul 2019 18:09:05 +0900 > >> Chanwoo Choi пишет: > >> > >>> On 19. 7. 16. 오후 10:35, Dmitry Osipenko wrote: >

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-18 Thread Chanwoo Choi
On 19. 7. 19. 오전 10:24, Chanwoo Choi wrote: > On 19. 7. 19. 오전 10:22, Dmitry Osipenko wrote: >> В Thu, 18 Jul 2019 18:09:05 +0900 >> Chanwoo Choi пишет: >> >>> On 19. 7. 16. 오후 10:35, Dmitry Osipenko wrote: 16.07.2019 15:26, Chanwoo Choi пишет: > Hi Dmitry, > > I'm not sure

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-18 Thread Chanwoo Choi
On 19. 7. 19. 오전 10:22, Dmitry Osipenko wrote: > В Thu, 18 Jul 2019 18:09:05 +0900 > Chanwoo Choi пишет: > >> On 19. 7. 16. 오후 10:35, Dmitry Osipenko wrote: >>> 16.07.2019 15:26, Chanwoo Choi пишет: Hi Dmitry, I'm not sure that it is necessary. As I knew, usally, the

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-18 Thread Dmitry Osipenko
В Thu, 18 Jul 2019 18:09:05 +0900 Chanwoo Choi пишет: > On 19. 7. 16. 오후 10:35, Dmitry Osipenko wrote: > > 16.07.2019 15:26, Chanwoo Choi пишет: > >> Hi Dmitry, > >> > >> I'm not sure that it is necessary. > >> As I knew, usally, the 'inline' is used on header file > >> to define the empty

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-18 Thread Chanwoo Choi
On 19. 7. 16. 오후 10:35, Dmitry Osipenko wrote: > 16.07.2019 15:26, Chanwoo Choi пишет: >> Hi Dmitry, >> >> I'm not sure that it is necessary. >> As I knew, usally, the 'inline' is used on header file >> to define the empty functions. >> >> Do we have to change it with 'inline' keyword? > > The

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-16 Thread Dmitry Osipenko
16.07.2019 15:26, Chanwoo Choi пишет: > Hi Dmitry, > > I'm not sure that it is necessary. > As I knew, usally, the 'inline' is used on header file > to define the empty functions. > > Do we have to change it with 'inline' keyword? The 'inline' attribute tells compiler that instead of jumping

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, I'm not sure that it is necessary. As I knew, usally, the 'inline' is used on header file to define the empty functions. Do we have to change it with 'inline' keyword? On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Depending on a kernel's configuration, a single line functions may

[PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-07 Thread Dmitry Osipenko
Depending on a kernel's configuration, a single line functions may not be inlined by compiler (like enabled ftracing for example). Let's inline such functions explicitly for consistency. Signed-off-by: Dmitry Osipenko --- drivers/devfreq/tegra30-devfreq.c | 13 +++-- 1 file changed, 7