On Fri, Mar 27, 2015 at 09:16:17AM +0800, yakir wrote:
> On 2015年03月27日 02:16, Mark Brown wrote:
> >>+free_cpu_of_node:
> >>+ hdmi_audio_dai.cpu_of_node = NULL;
> >>+ hdmi_audio_dai.platform_of_node = NULL;
> >>+free_priv_data:
> >>+ snd_soc_card_set_drvdata(card, NULL);
> >>+
Hi Mark,
On 2015年03月27日 02:16, Mark Brown wrote:
On Sat, Feb 28, 2015 at 10:04:30PM -0500, Yakir Yang wrote:
+ ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt);
+ if (ret < 0) {
+ dev_err(cpu_dai->dev, "failed to set cpu_dai fmt.\n");
+ return ret;
+ }
On Sat, Feb 28, 2015 at 10:04:30PM -0500, Yakir Yang wrote:
> + ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt);
> + if (ret < 0) {
> + dev_err(cpu_dai->dev, "failed to set cpu_dai fmt.\n");
> + return ret;
> + }
You've already set this in the dai_link, no need to
On Sat, Feb 28, 2015 at 10:04:30PM -0500, Yakir Yang wrote:
+ ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt);
+ if (ret 0) {
+ dev_err(cpu_dai-dev, failed to set cpu_dai fmt.\n);
+ return ret;
+ }
You've already set this in the dai_link, no need to do it
Hi Mark,
On 2015年03月27日 02:16, Mark Brown wrote:
On Sat, Feb 28, 2015 at 10:04:30PM -0500, Yakir Yang wrote:
+ ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt);
+ if (ret 0) {
+ dev_err(cpu_dai-dev, failed to set cpu_dai fmt.\n);
+ return ret;
+ }
On Fri, Mar 27, 2015 at 09:16:17AM +0800, yakir wrote:
On 2015年03月27日 02:16, Mark Brown wrote:
+free_cpu_of_node:
+ hdmi_audio_dai.cpu_of_node = NULL;
+ hdmi_audio_dai.platform_of_node = NULL;
+free_priv_data:
+ snd_soc_card_set_drvdata(card, NULL);
+ platform_set_drvdata(pdev,
在 2015/3/2 17:07, Paul Bolle 写道:
On Sat, 2015-02-28 at 22:04 -0500, Yakir Yang wrote:
--- /dev/null
+++ b/sound/soc/rockchip/rockchip_hdmi_audio.c
@@ -0,0 +1,169 @@
+/*
+ * rockchip-hdmi-card.c
Doesn't match the filename. Is this line needed anyway?
Thanks, this comment are good for read,
On Sat, 2015-02-28 at 22:04 -0500, Yakir Yang wrote:
> --- /dev/null
> +++ b/sound/soc/rockchip/rockchip_hdmi_audio.c
> @@ -0,0 +1,169 @@
> +/*
> + * rockchip-hdmi-card.c
Doesn't match the filename. Is this line needed anyway?
> + *
> + * ROCKCHIP ALSA SoC DAI driver for HDMI audio on rockchip
On Sat, 2015-02-28 at 22:04 -0500, Yakir Yang wrote:
--- /dev/null
+++ b/sound/soc/rockchip/rockchip_hdmi_audio.c
@@ -0,0 +1,169 @@
+/*
+ * rockchip-hdmi-card.c
Doesn't match the filename. Is this line needed anyway?
+ *
+ * ROCKCHIP ALSA SoC DAI driver for HDMI audio on rockchip
在 2015/3/2 17:07, Paul Bolle 写道:
On Sat, 2015-02-28 at 22:04 -0500, Yakir Yang wrote:
--- /dev/null
+++ b/sound/soc/rockchip/rockchip_hdmi_audio.c
@@ -0,0 +1,169 @@
+/*
+ * rockchip-hdmi-card.c
Doesn't match the filename. Is this line needed anyway?
Thanks, this comment are good for read,
Add a sound driver that combines rockchip-i2s cpu_dai and dw-hdmi-codec
as codec_dai to provide hdmi audio output on rk3288 platforms.
Signed-off-by: Yakir Yang
---
Changes in v4:
- Add ".pm = _soc_pm_ops,"
Changes in v3:
- Delete the operation of jack in rockchip-hdmi-audio driver,
get ready
Add a sound driver that combines rockchip-i2s cpu_dai and dw-hdmi-codec
as codec_dai to provide hdmi audio output on rk3288 platforms.
Signed-off-by: Yakir Yang y...@rock-chips.com
---
Changes in v4:
- Add .pm = snd_soc_pm_ops,
Changes in v3:
- Delete the operation of jack in rockchip-hdmi-audio
12 matches
Mail list logo
