Re: [PATCH v4 14/15] perf report: use srcline from callchain for hist entries

2017-10-09 Thread Milian Wolff
On Donnerstag, 5. Oktober 2017 06:08:29 CEST Namhyung Kim wrote: > On Sun, Oct 01, 2017 at 04:30:59PM +0200, Milian Wolff wrote: > > This also removes the symbol name from the srcline column, > > more on this below. > > > > This ensures we use the correct srcline, which could originate > > from a

Re: [PATCH v4 14/15] perf report: use srcline from callchain for hist entries

2017-10-04 Thread Namhyung Kim
On Sun, Oct 01, 2017 at 04:30:59PM +0200, Milian Wolff wrote: > This also removes the symbol name from the srcline column, > more on this below. > > This ensures we use the correct srcline, which could originate > from a potentially inlined function. The hist entries used to > query for the srclin

[PATCH v4 14/15] perf report: use srcline from callchain for hist entries

2017-10-01 Thread Milian Wolff
This also removes the symbol name from the srcline column, more on this below. This ensures we use the correct srcline, which could originate from a potentially inlined function. The hist entries used to query for the srcline based purely on the IP, which leads to wrong results for inlined entries