Re: [PATCH v4 14/16] block: sed-opal: pass steps via argument rather than via opal_dev

2019-02-04 Thread Christoph Hellwig
On Fri, Feb 01, 2019 at 09:50:21PM +0100, David Kozub wrote: > The steps argument is only read by the next function, so it can > be passed directly as an argument rather than via opal_dev. > > Normally, the steps is an array on the stack, so the pointer stops > being valid then the function that s

[PATCH v4 14/16] block: sed-opal: pass steps via argument rather than via opal_dev

2019-02-01 Thread David Kozub
The steps argument is only read by the next function, so it can be passed directly as an argument rather than via opal_dev. Normally, the steps is an array on the stack, so the pointer stops being valid then the function that set opal_dev.steps returns. If opal_dev.steps was not set to NULL before