Re: [PATCH v4 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-02-11 Thread Derrick, Jonathan
Hi David, On Sun, 2019-02-10 at 18:46 +0100, David Kozub wrote: > On Fri, 8 Feb 2019, Derrick, Jonathan wrote: > > > On Mon, 2019-02-04 at 23:44 +0100, David Kozub wrote: > > > On Mon, 4 Feb 2019, Christoph Hellwig wrote: > > > > > > > > + /* first do a discovery0 */ > > > > > + error =

Re: [PATCH v4 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-02-10 Thread David Kozub
On Fri, 8 Feb 2019, Derrick, Jonathan wrote: On Mon, 2019-02-04 at 23:44 +0100, David Kozub wrote: On Mon, 4 Feb 2019, Christoph Hellwig wrote: + /* first do a discovery0 */ + error = opal_discovery0_step(dev); + for (state = 0; !error && state < n_steps; state++) +

Re: [PATCH v4 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-02-08 Thread Derrick, Jonathan
On Mon, 2019-02-04 at 23:44 +0100, David Kozub wrote: > On Mon, 4 Feb 2019, Christoph Hellwig wrote: > > > > + /* first do a discovery0 */ > > > + error = opal_discovery0_step(dev); > > > > > > + for (state = 0; !error && state < n_steps; state++) > > > + error = execute_step(dev, &steps[

Re: [PATCH v4 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-02-04 Thread David Kozub
On Mon, 4 Feb 2019, Christoph Hellwig wrote: + /* first do a discovery0 */ + error = opal_discovery0_step(dev); + for (state = 0; !error && state < n_steps; state++) + error = execute_step(dev, &steps[state], state); + + /* +* For each OPAL command

Re: [PATCH v4 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-02-04 Thread Christoph Hellwig
> + /* first do a discovery0 */ > + error = opal_discovery0_step(dev); > > + for (state = 0; !error && state < n_steps; state++) > + error = execute_step(dev, &steps[state], state); > + > + /* > + * For each OPAL command the first step in steps starts some sort of

[PATCH v4 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-02-01 Thread David Kozub
Originally each of the opal functions that call next include opal_discovery0 in the array of steps. This is superfluous and can be done always inside next. Signed-off-by: David Kozub Reviewed-by: Scott Bauer --- block/sed-opal.c | 89 +++- 1 file chan