Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Xiaoyao Li
On Mon, 2019-03-04 at 12:14 +0100, Paolo Bonzini wrote: > On 04/03/19 12:10, Xiaoyao Li wrote: > > Like you said before, I think we don't need the condition judgment > > "if(boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT))", but to set > > F(CORE_CAPABILITY) > > always for guest since

Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Xiaoyao Li
On Mon, 2019-03-04 at 12:14 +0100, Paolo Bonzini wrote: > On 04/03/19 12:10, Xiaoyao Li wrote: > > Like you said before, I think we don't need the condition judgment > > "if(boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT))", but to set > > F(CORE_CAPABILITY) > > always for guest since

Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Paolo Bonzini
On 04/03/19 12:10, Xiaoyao Li wrote: > Like you said before, I think we don't need the condition judgment > "if(boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT))", but to set > F(CORE_CAPABILITY) > always for guest since MSR_IA32_CORE_CAPABILITY is emulated. > > And we should set the right emulated

Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Xiaoyao Li
On Mon, 2019-03-04 at 11:49 +0100, Paolo Bonzini wrote: > On 04/03/19 11:47, Xiaoyao Li wrote: > > On Mon, 2019-03-04 at 09:38 +0100, Paolo Bonzini wrote: > > > On 02/03/19 03:45, Fenghua Yu wrote: > > > > From: Xiaoyao Li > > > > > > > > In the latest Intel SDM, CPUID.(EAX=7H,ECX=0):EDX[30]

Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Paolo Bonzini
On 04/03/19 11:47, Xiaoyao Li wrote: > On Mon, 2019-03-04 at 09:38 +0100, Paolo Bonzini wrote: >> On 02/03/19 03:45, Fenghua Yu wrote: >>> From: Xiaoyao Li >>> >>> In the latest Intel SDM, CPUID.(EAX=7H,ECX=0):EDX[30] will enumerate >>> the presence of the IA32_CORE_CAPABILITY MSR. >>> >>> Update

Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Xiaoyao Li
On Mon, 2019-03-04 at 09:38 +0100, Paolo Bonzini wrote: > On 02/03/19 03:45, Fenghua Yu wrote: > > From: Xiaoyao Li > > > > In the latest Intel SDM, CPUID.(EAX=7H,ECX=0):EDX[30] will enumerate > > the presence of the IA32_CORE_CAPABILITY MSR. > > > > Update GET_SUPPORTED_CPUID to expose this

Re: [PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-04 Thread Paolo Bonzini
On 02/03/19 03:45, Fenghua Yu wrote: > From: Xiaoyao Li > > In the latest Intel SDM, CPUID.(EAX=7H,ECX=0):EDX[30] will enumerate > the presence of the IA32_CORE_CAPABILITY MSR. > > Update GET_SUPPORTED_CPUID to expose this feature bit to user space, so > that user space know this bit can be

[PATCH v4 15/17] kvm: x86: Report CORE_CAPABILITY on GET_SUPPORTED_CPUID

2019-03-01 Thread Fenghua Yu
From: Xiaoyao Li In the latest Intel SDM, CPUID.(EAX=7H,ECX=0):EDX[30] will enumerate the presence of the IA32_CORE_CAPABILITY MSR. Update GET_SUPPORTED_CPUID to expose this feature bit to user space, so that user space know this bit can be enabled in CPUID. Signed-off-by: Xiaoyao Li ---