Re: [PATCH v4 17/19] sched: Add migrate_disable() tracepoints

2020-10-29 Thread Peter Zijlstra
On Thu, Oct 29, 2020 at 05:56:12PM +, Valentin Schneider wrote: > > On 29/10/20 17:43, Peter Zijlstra wrote: > > On Thu, Oct 29, 2020 at 04:27:26PM +, Valentin Schneider wrote: > >> Don't you want those directly after the ->migration_disabled write? > >> esp. for migrate_enable(), if that

Re: [PATCH v4 17/19] sched: Add migrate_disable() tracepoints

2020-10-29 Thread Valentin Schneider
On 29/10/20 17:43, Peter Zijlstra wrote: > On Thu, Oct 29, 2020 at 04:27:26PM +, Valentin Schneider wrote: >> Don't you want those directly after the ->migration_disabled write? >> esp. for migrate_enable(), if that preempt_enable() leads to a context >> switch then the disable->enable deltas

Re: [PATCH v4 17/19] sched: Add migrate_disable() tracepoints

2020-10-29 Thread Peter Zijlstra
On Thu, Oct 29, 2020 at 04:27:26PM +, Valentin Schneider wrote: > > On 23/10/20 11:12, Peter Zijlstra wrote: > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -1732,6 +1732,8 @@ void migrate_disable(void) > > return; > > } > > > > + trace_sched_migrate_di

Re: [PATCH v4 17/19] sched: Add migrate_disable() tracepoints

2020-10-29 Thread Valentin Schneider
On 23/10/20 11:12, Peter Zijlstra wrote: > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1732,6 +1732,8 @@ void migrate_disable(void) > return; > } > > + trace_sched_migrate_disable_tp(p); > + > preempt_disable(); > this_rq()->nr_pinned++; >

[PATCH v4 17/19] sched: Add migrate_disable() tracepoints

2020-10-23 Thread Peter Zijlstra
XXX write a tracer: - 'migirate_disable() -> migrate_enable()' time in task_sched_runtime() - 'migrate_pull -> sched-in' time in task_sched_runtime() The first will give worst case for the second, which is the actual interference experienced by the task to due migration constraints of migrate_d