Hi Dmitry,
I understand what's missing now.
Thanks,
Scott
On 15-03-02 12:23 PM, Dmitry Torokhov wrote:
Hi Scott,
Hmm, also bcm_kp_start() and bcm_kp_stop() should check if kp->clk is
valid before trying to enable/disable it.
I checked and other keyboard drivers do not check this. I retur
Hi Scott,
On Mon, Mar 02, 2015 at 11:37:57AM -0800, Scott Branden wrote:
> Hi Dmitry,
>
> I don't see the need for a check of the clock in bcm_kp_start or
> stop. See comment below.
>
> On 15-02-28 02:15 PM, Dmitry Torokhov wrote:
> >On Sat, Feb 28, 2015 at 02:10:22PM -0800, Dmitry Torokhov wrot
Hi Dmitry,
I don't see the need for a check of the clock in bcm_kp_start or stop.
See comment below.
On 15-02-28 02:15 PM, Dmitry Torokhov wrote:
On Sat, Feb 28, 2015 at 02:10:22PM -0800, Dmitry Torokhov wrote:
Hi Scott,
On Sat, Feb 28, 2015 at 08:35:57AM -0800, Scott Branden wrote:
+
Hi Dmitry,
Yes, please improve the driver and make the local change.
Regards,
Scott
On 15-02-28 02:15 PM, Dmitry Torokhov wrote:
On Sat, Feb 28, 2015 at 02:10:22PM -0800, Dmitry Torokhov wrote:
Hi Scott,
On Sat, Feb 28, 2015 at 08:35:57AM -0800, Scott Branden wrote:
+ /* Enable clock
On Sat, Feb 28, 2015 at 02:10:22PM -0800, Dmitry Torokhov wrote:
> Hi Scott,
>
> On Sat, Feb 28, 2015 at 08:35:57AM -0800, Scott Branden wrote:
> > + /* Enable clock */
> > +
> > + kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> > + if (IS_ERR(kp->clk)) {
> > + dev_info(&pdev->de
Hi Scott,
On Sat, Feb 28, 2015 at 08:35:57AM -0800, Scott Branden wrote:
> + /* Enable clock */
> +
> + kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> + if (IS_ERR(kp->clk)) {
> + dev_info(&pdev->dev,
> + "No clock specified. Assuming it's enabled\n")
Add driver for Broadcom's keypad controller.
Broadcom Keypad controller is used to interface a SoC with a matrix-type
keypad device. The keypad controller supports multiple row and column lines.
A key can be placed at each intersection of a unique row and a unique column.
The keypad controller can
7 matches
Mail list logo
