Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-04 Thread Ray Jui
Hi Lorenzo, On 4/3/2019 4:31 AM, Lorenzo Pieralisi wrote: > On Wed, Apr 03, 2019 at 08:41:44AM +0530, Srinath Mannam wrote: >> Hi Lorenzo, >> >> Please see my reply below, >> >> On Tue, Apr 2, 2019 at 7:08 PM Lorenzo Pieralisi >> wrote: >>> >>> On Tue, Apr 02, 2019 at 04:16:13PM +0530, Srinath Ma

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-03 Thread Srinath Mannam
Hi Lorenzo, I am sorry, I took your long time. In my commit log I gave details about purpose of feature instead of implementation. Thanks a lot for all inputs and knowledge. I will remember and follow these notes while writing commit log. commit log re-written by you is very much impressive and ha

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-03 Thread Lorenzo Pieralisi
On Wed, Apr 03, 2019 at 08:41:44AM +0530, Srinath Mannam wrote: > Hi Lorenzo, > > Please see my reply below, > > On Tue, Apr 2, 2019 at 7:08 PM Lorenzo Pieralisi > wrote: > > > > On Tue, Apr 02, 2019 at 04:16:13PM +0530, Srinath Mannam wrote: > > > > [...] > > > > > > Ok - I start to understand.

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Srinath Mannam
Hi Lorenzo, Please see my reply below, On Tue, Apr 2, 2019 at 7:08 PM Lorenzo Pieralisi wrote: > > On Tue, Apr 02, 2019 at 04:16:13PM +0530, Srinath Mannam wrote: > > [...] > > > > Ok - I start to understand. What does it mean in HW terms that your > > > 32bit AXI address region size is 32MB ? P

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Lorenzo Pieralisi
On Tue, Apr 02, 2019 at 04:16:13PM +0530, Srinath Mannam wrote: [...] > > Ok - I start to understand. What does it mean in HW terms that your > > 32bit AXI address region size is 32MB ? Please explain to me in details. > > > In our PCIe controller HW, AXI address from 0x4200 to 0x4400 > o

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Srinath Mannam
Hi Lorenzo, Please see my reply below, On Tue, Apr 2, 2019 at 3:56 PM Lorenzo Pieralisi wrote: > > On Tue, Apr 02, 2019 at 03:20:21PM +0530, Srinath Mannam wrote: > > Hi Ray, > > > > Thanks for detailed explanation. > > Please see some more details below. > > > > On Tue, Apr 2, 2019 at 3:33 AM R

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Lorenzo Pieralisi
On Tue, Apr 02, 2019 at 03:20:21PM +0530, Srinath Mannam wrote: > Hi Ray, > > Thanks for detailed explanation. > Please see some more details below. > > On Tue, Apr 2, 2019 at 3:33 AM Ray Jui wrote: > > > > Hi Lorenzo/Srinath, > > > > I look at the commit message again and indeed it looks quite

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-02 Thread Srinath Mannam
Hi Ray, Thanks for detailed explanation. Please see some more details below. On Tue, Apr 2, 2019 at 3:33 AM Ray Jui wrote: > > Hi Lorenzo/Srinath, > > I look at the commit message again and indeed it looks quite confusing. > > I'll add my comment inline in the code section. I hope that will help

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-01 Thread Ray Jui
Hi Lorenzo/Srinath, I look at the commit message again and indeed it looks quite confusing. I'll add my comment inline in the code section. I hope that will help to make it more clear. On 4/1/2019 9:44 AM, Lorenzo Pieralisi wrote: > On Mon, Apr 01, 2019 at 11:04:48AM +0530, Srinath Mannam wrote:

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-04-01 Thread Lorenzo Pieralisi
On Mon, Apr 01, 2019 at 11:04:48AM +0530, Srinath Mannam wrote: > Hi Lorenzo, > > Please see my reply below, > > On Fri, Mar 29, 2019 at 11:06 PM Lorenzo Pieralisi > wrote: > > > > On Fri, Mar 01, 2019 at 10:22:16AM +0530, Srinath Mannam wrote: > > > In the present driver outbound window configu

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-03-31 Thread Srinath Mannam
Hi Lorenzo, Please see my reply below, On Fri, Mar 29, 2019 at 11:06 PM Lorenzo Pieralisi wrote: > > On Fri, Mar 01, 2019 at 10:22:16AM +0530, Srinath Mannam wrote: > > In the present driver outbound window configuration is done to map above > > 32-bit address I/O regions with corresponding PCI

Re: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-03-29 Thread Lorenzo Pieralisi
On Fri, Mar 01, 2019 at 10:22:16AM +0530, Srinath Mannam wrote: > In the present driver outbound window configuration is done to map above > 32-bit address I/O regions with corresponding PCI memory range given in > ranges DT property. > > This patch add outbound window configuration to map below 3

[PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region

2019-02-28 Thread Srinath Mannam
In the present driver outbound window configuration is done to map above 32-bit address I/O regions with corresponding PCI memory range given in ranges DT property. This patch add outbound window configuration to map below 32-bit I/O range with corresponding PCI memory, which helps to access I/O r