Re: [PATCH v4 2/2] blk-throttle: trim tokens generated for an idle tree

2013-10-27 Thread Hong zhi guo
Hi, Vivek, I tested the PATCH v4 for some basic hierarchical setup as I did before. And I get the similar result. Preparation 1) mount subsys blkio with "__DEVEL__sane_behavior" 2) Create 3 levels of directories under the blkio mount point: mkdir 1 mkdir 1/2 mkdir 1/2/3

Re: [PATCH v4 2/2] blk-throttle: trim tokens generated for an idle tree

2013-10-22 Thread Hong zhi guo
Hi, Vivek, Sorry I don't have time to test them carefully this week. I'll do it in this weekend. The updating of nr_queued_tree level by level only happens once for each bio. We have already the computing(and maybe queue operation) level by level for every bio, even it's passed through without be

Re: [PATCH v4 2/2] blk-throttle: trim tokens generated for an idle tree

2013-10-22 Thread Vivek Goyal
On Sun, Oct 20, 2013 at 08:11:12PM +0800, Hong Zhiguo wrote: > From: Hong Zhiguo > > Why > > Pointed out by Vivek: Tokens generated during idle period should > be trimmed. Otherwise a huge bio may be permited immediately. > Overlimit behaviour may be observed during short I/O throughput > te

[PATCH v4 2/2] blk-throttle: trim tokens generated for an idle tree

2013-10-20 Thread Hong Zhiguo
From: Hong Zhiguo Why Pointed out by Vivek: Tokens generated during idle period should be trimmed. Otherwise a huge bio may be permited immediately. Overlimit behaviour may be observed during short I/O throughput test. Vivek also pointed out: We should not over-trim for hierarchical groups.