Re: [PATCH v4 2/2] dma: sprd: Add Spreadtrum DMA driver

Hi Vinod, On 23 October 2017 at 14:44, Vinod Koul wrote: > On Tue, Oct 10, 2017 at 01:23:01PM +0800, Baolin Wang wrote: >> +++ b/drivers/dma/sprd-dma.c >> @@ -0,0 +1,988 @@ >> +/* >> + * Copyright (C) 2017 Spreadtrum Communications Inc. >> + * >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >

Re: [PATCH v4 2/2] dma: sprd: Add Spreadtrum DMA driver

On Tue, Oct 10, 2017 at 01:23:01PM +0800, Baolin Wang wrote: > +++ b/drivers/dma/sprd-dma.c > @@ -0,0 +1,988 @@ > +/* > + * Copyright (C) 2017 Spreadtrum Communications Inc. > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) MIT? See comment for MODULE_LICENSE > +/* SPRD_DMA_CHN_CFG register

Re: [PATCH v4 2/2] dma: sprd: Add Spreadtrum DMA driver

Hi Vinod, On 10 October 2017 at 13:23, Baolin Wang wrote: > This patch adds the DMA controller driver for Spreadtrum SC9860 platform. > > Signed-off-by: Baolin Wang > --- > Changes since v3: > - Remove redundant local 'mask' and 'val' variables. > - Simplify sprd_dma_get_req_type() function. >

[PATCH v4 2/2] dma: sprd: Add Spreadtrum DMA driver

This patch adds the DMA controller driver for Spreadtrum SC9860 platform. Signed-off-by: Baolin Wang --- Changes since v3: - Remove redundant local 'mask' and 'val' variables. - Simplify sprd_dma_get_req_type() function. - Change pm_runtime_put_sync() to pm_runtime_put() in probe function. -