Re: [PATCH v4 2/2] drivers/base/memory.c: Rename the misleading parameter

2019-03-29 Thread Mukesh Ojha
On 3/29/2019 3:06 PM, Baoquan He wrote: The input parameter 'phys_index' of memory_block_action() is actually the section number, but not the phys_index of memory_block. This is a relict from the past when one memory block could only contain one section. Rename it to start_section_nr. Signed-

Re: [PATCH v4 2/2] drivers/base/memory.c: Rename the misleading parameter

2019-03-29 Thread Oscar Salvador
On Fri, Mar 29, 2019 at 05:36:59PM +0800, Baoquan He wrote: > The input parameter 'phys_index' of memory_block_action() is actually > the section number, but not the phys_index of memory_block. This is > a relict from the past when one memory block could only contain one > section. > > Rename it t

[PATCH v4 2/2] drivers/base/memory.c: Rename the misleading parameter

2019-03-29 Thread Baoquan He
The input parameter 'phys_index' of memory_block_action() is actually the section number, but not the phys_index of memory_block. This is a relict from the past when one memory block could only contain one section. Rename it to start_section_nr. Signed-off-by: Baoquan He Acked-by: Michal Hocko