Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock

2017-07-01 Thread Vladimir Davydov
On Thu, Jun 29, 2017 at 09:09:35AM +0530, Sahitya Tummala wrote: > __list_lru_walk_one() acquires nlru spin lock (nlru->lock) for > longer duration if there are more number of items in the lru list. > As per the current code, it can hold the spin lock for upto maximum > UINT_MAX entries at a time.

Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock

2017-06-29 Thread Sahitya Tummala
On 6/30/2017 4:18 AM, Andrew Morton wrote: --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1133,11 +1133,12 @@ void shrink_dcache_sb(struct super_block *sb) LIST_HEAD(dispose); freed = list_lru_walk(&sb->s_dentry_lru, - dentry_lru_isolate_shrink, &dispose,

Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock

2017-06-29 Thread Andrew Morton
On Thu, 29 Jun 2017 09:09:35 +0530 Sahitya Tummala wrote: > __list_lru_walk_one() acquires nlru spin lock (nlru->lock) for > longer duration if there are more number of items in the lru list. > As per the current code, it can hold the spin lock for upto maximum > UINT_MAX entries at a time. So i

[PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock

2017-06-28 Thread Sahitya Tummala
__list_lru_walk_one() acquires nlru spin lock (nlru->lock) for longer duration if there are more number of items in the lru list. As per the current code, it can hold the spin lock for upto maximum UINT_MAX entries at a time. So if there are more number of items in the lru list, then "BUG: spinlock