Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-11 Thread Michael Hennerich
On 06.04.2017 22:03, Peter Rosin wrote: On 2017-04-06 13:31, Michael Hennerich wrote: On 06.04.2017 10:39, Peter Rosin wrote: Hi Peter, again - thanks for your review. Comments below. +static const struct regmap_config ltc4306_regmap_config = { + .reg_bits = 8, + .val_bits = 8,

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-11 Thread Michael Hennerich
On 10.04.2017 22:04, Linus Walleij wrote: On Wed, Apr 5, 2017 at 3:07 PM, wrote: From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose input

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-10 Thread Linus Walleij
On Wed, Apr 5, 2017 at 3:07 PM, wrote: > From: Michael Hennerich > > This patch adds support for the Analog Devices / Linear Technology > LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. > The LTC4306 optionally provides two general purpose input/output pins > (GPIOs) that can be c

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-06 Thread Peter Rosin
On 2017-04-06 13:31, Michael Hennerich wrote: > On 06.04.2017 10:39, Peter Rosin wrote: >> Hi Michael, >> >> I would still like to hear from someone with more gpio experience. > > I'll ping Linus. > >> >> Anyway, from my point of view, there's just a few minor things left, >> with comments inline

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-06 Thread Michael Hennerich
On 06.04.2017 10:39, Peter Rosin wrote: Hi Michael, I would still like to hear from someone with more gpio experience. I'll ping Linus. Anyway, from my point of view, there's just a few minor things left, with comments inline as usual. Thanks for you patience! Thanks for review. Cheer

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-06 Thread Peter Rosin
Hi Michael, I would still like to hear from someone with more gpio experience. Anyway, from my point of view, there's just a few minor things left, with comments inline as usual. Thanks for you patience! Cheers, peda On 2017-04-05 15:07, michael.henner...@analog.com wrote: > From: Michael Henn

[PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-05 Thread michael.hennerich
From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose input/output pins (GPIOs) that can be configured as logic inputs, opendrain outputs or push-