Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-12 Thread Ingi Kim
Hi Jacek, On 2015년 11월 12일 18:21, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/12/2015 08:57 AM, Ingi Kim wrote: > [...] +regmap_write(led->regmap, RT5033_REG_FLED_FUNCTION1, val); +} else { +regmap_update_bits(led->regmap, RT5033_REG_FLED_FUNCTION1, +

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-12 Thread Jacek Anaszewski
Hi Ingi, On 11/12/2015 08:57 AM, Ingi Kim wrote: [...] +regmap_write(led->regmap, RT5033_REG_FLED_FUNCTION1, val); +} else { +regmap_update_bits(led->regmap, RT5033_REG_FLED_FUNCTION1, + RT5033_FLED_FUNC1_MASK, RT5033_FLED_PINCTRL | +

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-12 Thread Jacek Anaszewski
Hi Ingi, On 11/12/2015 08:57 AM, Ingi Kim wrote: [...] +regmap_write(led->regmap, RT5033_REG_FLED_FUNCTION1, val); +} else { +regmap_update_bits(led->regmap, RT5033_REG_FLED_FUNCTION1, + RT5033_FLED_FUNC1_MASK, RT5033_FLED_PINCTRL | +

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-12 Thread Ingi Kim
Hi Jacek, On 2015년 11월 12일 18:21, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/12/2015 08:57 AM, Ingi Kim wrote: > [...] +regmap_write(led->regmap, RT5033_REG_FLED_FUNCTION1, val); +} else { +regmap_update_bits(led->regmap, RT5033_REG_FLED_FUNCTION1, +

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-11 Thread Ingi Kim
Hi Jacek, Thanks for the review. your feedback is highly appreciated :) I'll send next patch set soon. On 2015년 11월 11일 01:30, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. Please find my comments below. > > On 11/10/2015 03:17 AM, Ingi Kim wrote: >> This patch adds device

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-11 Thread Ingi Kim
Hi Jacek, Thanks for the review. your feedback is highly appreciated :) I'll send next patch set soon. On 2015년 11월 11일 01:30, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. Please find my comments below. > > On 11/10/2015 03:17 AM, Ingi Kim wrote: >> This patch adds device

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-10 Thread Jacek Anaszewski
Hi Ingi, Thanks for the update. Please find my comments below. On 11/10/2015 03:17 AM, Ingi Kim wrote: This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs. I would add here also the part from leds-rt5033.txt header.

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-10 Thread Jacek Anaszewski
Hi Ingi, Thanks for the update. Please find my comments below. On 11/10/2015 03:17 AM, Ingi Kim wrote: This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs. I would add here also the part from leds-rt5033.txt header.

[PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-09 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c | 502

[PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-09 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c