Re: [PATCH v4 2/2] platform/chrome: wilco_ec: Add telemetry char device interface

2019-05-09 Thread Enric Balletbo i Serra
Hi Nick, Many thanks for the patch, some few comments below. On 8/5/19 23:38, Nick Crews wrote: > The Wilco Embedded Controller is able to send telemetry data > which is useful for enterprise applications. A daemon running on > the OS sends a command to the EC via a write() to a char device, > an

[PATCH v4 2/2] platform/chrome: wilco_ec: Add telemetry char device interface

2019-05-08 Thread Nick Crews
The Wilco Embedded Controller is able to send telemetry data which is useful for enterprise applications. A daemon running on the OS sends a command to the EC via a write() to a char device, and can read the response with a read(). The write() request is verified by the driver to ensure that it is