Re: [PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Jacob Pan
On Fri, 19 Feb 2016 23:01:59 +0100 (CET) Thomas Gleixner wrote: > > > + if (lead_cpu < nr_cpu_ids) > > > + new_package->lead_cpu = > > > lead_cpu; > > > > So the above is identical to > > > >

Re: [PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Jacob Pan
On Fri, 19 Feb 2016 23:01:59 +0100 (CET) Thomas Gleixner wrote: > > > + if (lead_cpu < nr_cpu_ids) > > > + new_package->lead_cpu = > > > lead_cpu; > > > > So the above is identical to > > > > new_package->lead_cpu = lead_cpu; >

Re: [PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Thomas Gleixner
On Fri, 19 Feb 2016, Thomas Gleixner wrote: > On Fri, 19 Feb 2016, Jacob Pan wrote: > > @@ -1380,6 +1375,7 @@ static int rapl_detect_topology(void) > > int i; > > int phy_package_id; > > struct rapl_package *new_package, *rp; > > + int lead_cpu; > > > >

Re: [PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Thomas Gleixner
On Fri, 19 Feb 2016, Thomas Gleixner wrote: > On Fri, 19 Feb 2016, Jacob Pan wrote: > > @@ -1380,6 +1375,7 @@ static int rapl_detect_topology(void) > > int i; > > int phy_package_id; > > struct rapl_package *new_package, *rp; > > + int lead_cpu; > > > >

Re: [PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Thomas Gleixner
On Fri, 19 Feb 2016, Jacob Pan wrote: > @@ -1380,6 +1375,7 @@ static int rapl_detect_topology(void) > int i; > int phy_package_id; > struct rapl_package *new_package, *rp; > + int lead_cpu; > > for_each_online_cpu(i) { > phy_package_id =

Re: [PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Thomas Gleixner
On Fri, 19 Feb 2016, Jacob Pan wrote: > @@ -1380,6 +1375,7 @@ static int rapl_detect_topology(void) > int i; > int phy_package_id; > struct rapl_package *new_package, *rp; > + int lead_cpu; > > for_each_online_cpu(i) { > phy_package_id =

[PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Jacob Pan
Reduce remote CPU calls for MSR access by combining read modify write into one function. Also optimize calling active CPU on package by tracking a lead cpu for each package. Suggested-by: Peter Zijlstra Signed-off-by: Jacob Pan ---

[PATCH v4 2/2] powercap/rapl: reduce ipi calls

2016-02-19 Thread Jacob Pan
Reduce remote CPU calls for MSR access by combining read modify write into one function. Also optimize calling active CPU on package by tracking a lead cpu for each package. Suggested-by: Peter Zijlstra Signed-off-by: Jacob Pan --- drivers/powercap/intel_rapl.c | 224