Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-07 Thread caesar
Thierry, 在 2014年08月07日 21:14, Thierry Reding 写道: On Thu, Aug 07, 2014 at 09:04:30PM +0800, caesar wrote: [...] As you say, I will rewrite the about if it's really need do so it. For example: static const struct rockchip_pwm_data pwm_data_v1 = { .regs = { .duty = 0x04,

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-07 Thread Thierry Reding
On Thu, Aug 07, 2014 at 09:04:30PM +0800, caesar wrote: [...] > As you say, I will rewrite the about if it's really need do so it. > For example: > > static const struct rockchip_pwm_data pwm_data_v1 = { > .regs = { > .duty = 0x04, > .period = 0x08, >

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-07 Thread caesar
Thierry, 在 2014年08月07日 14:18, Thierry Reding 写道: On Thu, Jul 24, 2014 at 06:21:35PM +0800, Caesar Wang wrote: This patch added to support the PWM controller found on RK3288 SoC. Signed-off-by: Caesar Wang --- drivers/pwm/pwm-rockchip.c | 124 ++--- 1

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread Thierry Reding
On Thu, Jul 24, 2014 at 06:21:35PM +0800, Caesar Wang wrote: > This patch added to support the PWM controller found on > RK3288 SoC. > > Signed-off-by: Caesar Wang > --- > drivers/pwm/pwm-rockchip.c | 124 > ++--- > 1 file changed, 105 insertions(+), 19 d

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread Thierry Reding
On Wed, Aug 06, 2014 at 08:26:51PM -0700, Doug Anderson wrote: > caesar, > > On Wed, Aug 6, 2014 at 8:23 PM, caesar wrote: > > > > 在 2014年08月07日 10:16, Doug Anderson 写道: > > > >> Caesar, > >> > >> On Wed, Aug 6, 2014 at 6:27 PM, caesar wrote: > >>> > >>> Doug, > >>> > >>> 在 2014年08月07日 06:46, Do

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread caesar
Doug, 在 2014年08月07日 11:46, Doug Anderson 写道: Caesar, On Wed, Aug 6, 2014 at 8:37 PM, caesar wrote: Doug, 在 2014年08月07日 11:26, Doug Anderson 写道: caesar, On Wed, Aug 6, 2014 at 8:23 PM, caesar wrote: 在 2014年08月07日 10:16, Doug Anderson 写道: Caesar, On Wed, Aug 6, 2014 at 6:27 PM, caesar

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread Doug Anderson
Caesar, On Wed, Aug 6, 2014 at 8:37 PM, caesar wrote: > Doug, > > 在 2014年08月07日 11:26, Doug Anderson 写道: > >> caesar, >> >> On Wed, Aug 6, 2014 at 8:23 PM, caesar wrote: >>> >>> 在 2014年08月07日 10:16, Doug Anderson 写道: >>> Caesar, On Wed, Aug 6, 2014 at 6:27 PM, caesar wrote:

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread caesar
Doug, 在 2014年08月07日 11:26, Doug Anderson 写道: caesar, On Wed, Aug 6, 2014 at 8:23 PM, caesar wrote: 在 2014年08月07日 10:16, Doug Anderson 写道: Caesar, On Wed, Aug 6, 2014 at 6:27 PM, caesar wrote: Doug, 在 2014年08月07日 06:46, Doug Anderson 写道: Caesar, On Thu, Jul 24, 2014 at 3:21 AM, Caesar

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread Doug Anderson
caesar, On Wed, Aug 6, 2014 at 8:23 PM, caesar wrote: > > 在 2014年08月07日 10:16, Doug Anderson 写道: > >> Caesar, >> >> On Wed, Aug 6, 2014 at 6:27 PM, caesar wrote: >>> >>> Doug, >>> >>> 在 2014年08月07日 06:46, Doug Anderson 写道: >>> Caesar, On Thu, Jul 24, 2014 at 3:21 AM, Caesar Wang >

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread caesar
在 2014年08月07日 10:16, Doug Anderson 写道: Caesar, On Wed, Aug 6, 2014 at 6:27 PM, caesar wrote: Doug, 在 2014年08月07日 06:46, Doug Anderson 写道: Caesar, On Thu, Jul 24, 2014 at 3:21 AM, Caesar Wang wrote: +static const struct rockchip_pwm_data pwm_data_v1 = { + .regs.duty = PWM_HRC, +

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread Doug Anderson
Caesar, On Wed, Aug 6, 2014 at 6:27 PM, caesar wrote: > Doug, > > 在 2014年08月07日 06:46, Doug Anderson 写道: > >> Caesar, >> >> On Thu, Jul 24, 2014 at 3:21 AM, Caesar Wang >> wrote: >>> >>> +static const struct rockchip_pwm_data pwm_data_v1 = { >>> + .regs.duty = PWM_HRC, >>> + .regs.pe

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread caesar
Doug, 在 2014年08月07日 06:46, Doug Anderson 写道: Caesar, On Thu, Jul 24, 2014 at 3:21 AM, Caesar Wang wrote: +static const struct rockchip_pwm_data pwm_data_v1 = { + .regs.duty = PWM_HRC, + .regs.period = PWM_LRC, + .regs.cntr = PWM_CNTR, + .regs.ctrl = PWM_CTRL, + .

Re: [PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-08-06 Thread Doug Anderson
Caesar, On Thu, Jul 24, 2014 at 3:21 AM, Caesar Wang wrote: > +static const struct rockchip_pwm_data pwm_data_v1 = { > + .regs.duty = PWM_HRC, > + .regs.period = PWM_LRC, > + .regs.cntr = PWM_CNTR, > + .regs.ctrl = PWM_CTRL, > + .prescaler = PRESCALER, > + .set

[PATCH v4 2/2] pwm: rockchip: Added to support for RK3288 SoC

2014-07-24 Thread Caesar Wang
This patch added to support the PWM controller found on RK3288 SoC. Signed-off-by: Caesar Wang --- drivers/pwm/pwm-rockchip.c | 124 ++--- 1 file changed, 105 insertions(+), 19 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchi