Re: [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe

2019-03-26 Thread George Hilliard
On Tue, Mar 26, 2019 at 6:46 PM Greg Kroah-Hartman wrote: > > On Tue, Mar 26, 2019 at 09:21:39AM -0600, George Hilliard wrote: > > - init_completion(>cmd_done); > > + // The completion should have been consumed by the previous command > > + // response handler, because the mmc

Re: [PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe

2019-03-26 Thread Greg Kroah-Hartman
On Tue, Mar 26, 2019 at 09:21:39AM -0600, George Hilliard wrote: > The module was initializing completions whenever it was going to wait on > them, and not when the completion was allocated. This is incorrect > according to the completion docs: > > Calling init_completion() on the same

[PATCH v4 2/2] staging: mt7621-mmc: Initialize completions a single time during probe

2019-03-26 Thread George Hilliard
The module was initializing completions whenever it was going to wait on them, and not when the completion was allocated. This is incorrect according to the completion docs: Calling init_completion() on the same completion object twice is most likely a bug [...] Re-initialization is