Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-04-12 Thread Michal Simek
Hi Guenter, On 4/11/21 4:02 PM, Guenter Roeck wrote: > Michal, > > On 4/7/21 11:08 PM, Michal Simek wrote: > ... >> It looks like that you directly created the patch. Isn't it better to >> send it yourself? Or do you want Manish to create it based on guidance >> above? >> > -next is substantially

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-04-11 Thread Guenter Roeck
Michal, On 4/7/21 11:08 PM, Michal Simek wrote: ... > It looks like that you directly created the patch. Isn't it better to > send it yourself? Or do you want Manish to create it based on guidance > above? > -next is substantially broken all over the place. I already spend way too much time bisec

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-04-07 Thread Michal Simek
Hi Guenter, On 4/7/21 11:48 PM, Guenter Roeck wrote: > On Wed, Mar 17, 2021 at 12:22:29PM +0530, Manish Narani wrote: >> Add a new driver for supporting Xilinx platforms. This driver is used >> for some sequence of operations required for Xilinx USB controllers. >> This driver is also used to choo

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-04-07 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 12:22:29PM +0530, Manish Narani wrote: > Add a new driver for supporting Xilinx platforms. This driver is used > for some sequence of operations required for Xilinx USB controllers. > This driver is also used to choose between PIPE clock coming from SerDes > and the Suspend

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-24 Thread Rong Chen
On 3/23/21 7:47 PM, Greg KH wrote: On Wed, Mar 17, 2021 at 05:50:22PM +0800, kernel test robot wrote: Hi Manish, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.12-rc3 next-20210316] [If your pa

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-23 Thread Greg KH
On Wed, Mar 17, 2021 at 05:50:22PM +0800, kernel test robot wrote: > Hi Manish, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on usb/usb-testing] > [also build test WARNING on robh/for-next v5.12-rc3 next-20210316] > [If your patch is applied to the wrong

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-17 Thread kernel test robot
Hi Manish, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on robh/for-next v5.12-rc3 next-20210316] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

[PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-16 Thread Manish Narani
Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers. This driver is also used to choose between PIPE clock coming from SerDes and the Suspend Clock. Before the controller is out of reset, the clock selection shoul