Re: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 16:21:49 + Vitor Soares wrote: > > > > You're missing a kerneldoc here. > > I will do that. Can you clarify why we need that? > So the function is properly documented here [1]. > > > > > +const struct i3c_device_id * > > > +i3c_device_match_id(struct i3c_device *

RE: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Fri, Jul 12, 2019 at 17:03:38 > On Fri, 12 Jul 2019 13:53:29 +0200 > Vitor Soares wrote: > > > The i3c device driver needs the i3c_device_id table. > > "Some I3C device drivers need to know which entry matches the > i3c_device object passed to the probe f

Re: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Boris Brezillon
On Fri, 12 Jul 2019 13:53:29 +0200 Vitor Soares wrote: > The i3c device driver needs the i3c_device_id table. "Some I3C device drivers need to know which entry matches the i3c_device object passed to the probe function" > Lets move to device.c and export it to be used. "Let's move i3c_device

[PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Vitor Soares
The i3c device driver needs the i3c_device_id table. Lets move it to device.c and export it to be used. Signed-off-by: Vitor Soares --- Changes in v4: None Changes in v3: Remove i3c_get_device_id Move i3c_device_match_id from drivers/i3c/master.c to drivers/i3c/device.c Export i3c_device