Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-29 Thread Brian Norris
Hi Bayi, On Fri, Oct 30, 2015 at 10:12:39AM +0800, bayi.cheng wrote: > Hi Brian, The current station is as follows. > > 1: put 0x9F to MTK_NOR_PRGDATA5_REG, and five 0x0 to > MTK_NOR_PRGDATA4_REG ~ MTK_NOR_PRGDATA0_REG, then set (1 + 5) * 8 > to MTK_NOR_CNT_REG, for this way, we can read five I

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-29 Thread Brian Norris
On Thu, Oct 29, 2015 at 09:56:31PM +0800, bayi.cheng wrote: > On Thu, 2015-10-29 at 11:28 +0800, bayi.cheng wrote: > > On Wed, 2015-10-28 at 18:52 -0700, Brian Norris wrote: > > > On Sun, Oct 18, 2015 at 10:20:35PM +0800, bayi.cheng wrote: > > > > On Fri, 2015-10-16 at 00:39 -0700, Brian Norris wro

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-28 Thread Brian Norris
Hi Bayi, I'm looking over your v5, and I still have a lot of comments. I'll send those soon. But I still question one of your responses here: On Sun, Oct 18, 2015 at 10:20:35PM +0800, bayi.cheng wrote: > On Fri, 2015-10-16 at 00:39 -0700, Brian Norris wrote: > > On Tue, Oct 13, 2015 at 05:39:19PM

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-16 Thread Brian Norris
Hi Bayi, On Tue, Oct 13, 2015 at 05:39:19PM +0800, Bayi Cheng wrote: > add spi nor flash driver for mediatek controller > > Signed-off-by: Bayi Cheng > --- > drivers/mtd/spi-nor/Kconfig | 7 + > drivers/mtd/spi-nor/Makefile | 1 + > drivers/mtd/spi-nor/mtk-quadspi.c | 486 >

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-13 Thread kbuild test robot
Hi Bayi, [auto build test ERROR on mtd/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Bayi-Cheng/Mediatek-SPI-NOR-flash-driver/20151013-174438 config: x86_64-allmodconfig (attached as .config) rep

[PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-13 Thread Bayi Cheng
add spi nor flash driver for mediatek controller Signed-off-by: Bayi Cheng --- drivers/mtd/spi-nor/Kconfig | 7 + drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/mtk-quadspi.c | 486 ++ 3 files changed, 494 insertions(+) create mode 100