Re: [PATCH v4 2/4] ARM: Add atomic_io_modify optimized routines

2013-08-28 Thread Catalin Marinas
On Wed, Aug 28, 2013 at 11:01:22AM +0100, Thomas Petazzoni wrote: > Dear Ezequiel Garcia, > > On Wed, 28 Aug 2013 06:49:08 -0300, Ezequiel Garcia wrote: > > > > Is this any different from the generic one introduced in patch 1/4? I > > > would rather just use the generic definition. > > > > Well,

Re: [PATCH v4 2/4] ARM: Add atomic_io_modify optimized routines

2013-08-28 Thread Thomas Petazzoni
Dear Ezequiel Garcia, On Wed, 28 Aug 2013 06:49:08 -0300, Ezequiel Garcia wrote: > > Is this any different from the generic one introduced in patch 1/4? I > > would rather just use the generic definition. > > Well, according to Will Deacon (and as documented in the commit log) > we can optimize

Re: [PATCH v4 2/4] ARM: Add atomic_io_modify optimized routines

2013-08-28 Thread Ezequiel Garcia
On Wed, Aug 28, 2013 at 09:53:40AM +0100, Catalin Marinas wrote: > On Sat, Aug 24, 2013 at 04:35:30PM +0100, Ezequiel Garcia wrote: > > Implement arch-specific atomic_io_modify and atomic_io_modify_relaxed, > > which are based on writel/readl_relaxed and writel_relaxed/readl_relaxed, > > respective

Re: [PATCH v4 2/4] ARM: Add atomic_io_modify optimized routines

2013-08-28 Thread Catalin Marinas
On Sat, Aug 24, 2013 at 04:35:30PM +0100, Ezequiel Garcia wrote: > Implement arch-specific atomic_io_modify and atomic_io_modify_relaxed, > which are based on writel/readl_relaxed and writel_relaxed/readl_relaxed, > respectively. > In both cases, by relaxing the readl, perfomance can be improved. >

[PATCH v4 2/4] ARM: Add atomic_io_modify optimized routines

2013-08-24 Thread Ezequiel Garcia
Implement arch-specific atomic_io_modify and atomic_io_modify_relaxed, which are based on writel/readl_relaxed and writel_relaxed/readl_relaxed, respectively. In both cases, by relaxing the readl, perfomance can be improved. Signed-off-by: Ezequiel Garcia --- arch/arm/include/asm/io.h | 4