Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable()

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Doug, On 07/23/2016 12:04 PM, Doug Anderson wrote: Yakir, On Wed, Jul 13, 2016 at 9:15 PM, Yakir Yang wrote: +static void psr_set_state(struct psr_drv *psr, enum psr_state state) +{ + mutex_lock(&psr->state_mutex); + + if (psr->state == state) { + mutex_unlock(&psr->

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-22 Thread Doug Anderson
Yakir, On Wed, Jul 13, 2016 at 9:15 PM, Yakir Yang wrote: > +static void psr_set_state(struct psr_drv *psr, enum psr_state state) > +{ > + mutex_lock(&psr->state_mutex); > + > + if (psr->state == state) { > + mutex_unlock(&psr->state_mutex); > + return; > +

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable()

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-14 Thread Sean Paul
On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: > The PSR driver have exported four symbols for specific device driver: > - rockchip_drm_psr_register() > - rockchip_drm_psr_unregister() > - rockchip_drm_psr_enable() > - rockchip_drm_psr_disable() > - rockchip_drm_psr_flush() > > Encode

[PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-13 Thread Yakir Yang
The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable() - rockchip_drm_psr_flush() Encoder driver should call the register/unregister interfaces to hook itself into