Re: [PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-09-05 Thread Tomeu Vizoso
On 2 September 2016 at 16:50, Emil Velikov wrote: > Hi Tomeu, > > On 5 August 2016 at 11:45, Tomeu Vizoso wrote: > >> +#ifdef CONFIG_DEBUG_FS >> + spin_lock_init(>crc.lock); >> + init_waitqueue_head(>crc.wq); >> +

Re: [PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-09-05 Thread Tomeu Vizoso
On 2 September 2016 at 16:50, Emil Velikov wrote: > Hi Tomeu, > > On 5 August 2016 at 11:45, Tomeu Vizoso wrote: > >> +#ifdef CONFIG_DEBUG_FS >> + spin_lock_init(>crc.lock); >> + init_waitqueue_head(>crc.wq); >> + crtc->crc.source = kstrdup("auto", GFP_KERNEL); > Pedantic:

Re: [PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-09-02 Thread Emil Velikov
Hi Tomeu, On 5 August 2016 at 11:45, Tomeu Vizoso wrote: > +#ifdef CONFIG_DEBUG_FS > + spin_lock_init(>crc.lock); > + init_waitqueue_head(>crc.wq); > + crtc->crc.source = kstrdup("auto", GFP_KERNEL); Pedantic: kstrdup() can never fail ? > +#endif >

Re: [PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-09-02 Thread Emil Velikov
Hi Tomeu, On 5 August 2016 at 11:45, Tomeu Vizoso wrote: > +#ifdef CONFIG_DEBUG_FS > + spin_lock_init(>crc.lock); > + init_waitqueue_head(>crc.wq); > + crtc->crc.source = kstrdup("auto", GFP_KERNEL); Pedantic: kstrdup() can never fail ? > +#endif > + > if

[PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-08-05 Thread Tomeu Vizoso
Adds files and directories to debugfs for controlling and reading frame CRCs, per CRTC: dri/0/crtc-0/crc dri/0/crtc-0/crc/control dri/0/crtc-0/crc/data Drivers can implement the set_crc_source callback() in drm_crtc_funcs to start and stop generating frame CRCs and can add entries to the output

[PATCH v4 2/4] drm: Add API for capturing frame CRCs

2016-08-05 Thread Tomeu Vizoso
Adds files and directories to debugfs for controlling and reading frame CRCs, per CRTC: dri/0/crtc-0/crc dri/0/crtc-0/crc/control dri/0/crtc-0/crc/data Drivers can implement the set_crc_source callback() in drm_crtc_funcs to start and stop generating frame CRCs and can add entries to the output