Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-15 Thread Leo Yan
On Fri, Oct 16, 2015 at 11:42:54AM +0530, Jassi Brar wrote: > On 16 October 2015 at 11:38, Leo Yan wrote: > > On Fri, Oct 16, 2015 at 11:17:32AM +0530, Jassi Brar wrote: > >> On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan wrote: > >> > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: > >> >

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-15 Thread Jassi Brar
On 16 October 2015 at 11:38, Leo Yan wrote: > On Fri, Oct 16, 2015 at 11:17:32AM +0530, Jassi Brar wrote: >> On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan wrote: >> > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: >> >> On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: >> >> >> >> > + >>

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-15 Thread Leo Yan
On Fri, Oct 16, 2015 at 11:17:32AM +0530, Jassi Brar wrote: > On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan wrote: > > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: > >> On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > >> > >> > + > >> > +#define MBOX_CHAN_MAX 32 > >>

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-15 Thread Jassi Brar
On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan wrote: > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: >> On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: >> >> > + >> > +#define MBOX_CHAN_MAX 32 >> > +#define MBOX_CHAN_NUM 2 >> > + >> You mean the hardwa

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-15 Thread Leo Yan
On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: > On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > > > + > > +#define MBOX_CHAN_MAX 32 > > +#define MBOX_CHAN_NUM 2 > > + > You mean the hardware has 32 channels but this driver can not manage > more t

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-15 Thread Jassi Brar
On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > + > +#define MBOX_CHAN_MAX 32 > +#define MBOX_CHAN_NUM 2 > + You mean the hardware has 32 channels but this driver can not manage more than 2 ? OR, there are 32 interfaces but only 2 physical 'floating' links, s

[PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

2015-10-12 Thread Leo Yan
Add driver for Hi6220 mailbox, the mailbox communicates with MCU; for sending data, it can support two methods for low level implementation: one is to use interrupt as acknowledge, another is automatic mode which without any acknowledge. These two methods have been supported in the driver. For rece