Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-26 Thread Dwivedi, Avaneesh Kumar (avani)
On 5/26/2017 12:43 AM, Bjorn Andersson wrote: On Tue 16 May 11:02 PDT 2017, Avaneesh Kumar Dwivedi wrote: This patch refactor code to first load all firmware blobs and then update modem proc to authenticate and boot fw. Nice, I like this! Just some style details below. Thanks. Sure will cor

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-25 Thread Sricharan R
Hi Bjorn, On 5/26/2017 12:33 AM, Bjorn Andersson wrote: > On Mon 22 May 06:26 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: >> On 5/22/2017 4:07 PM, Sricharan R wrote: >>> Hi, >>> >>> On 5/22/2017 3:03 PM, Dwivedi, Avaneesh Kumar (avani) wrote: On 5/20/2017 8:25 AM, Sricharan R wrote:

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-25 Thread Bjorn Andersson
On Tue 16 May 11:02 PDT 2017, Avaneesh Kumar Dwivedi wrote: > This patch refactor code to first load all firmware blobs > and then update modem proc to authenticate and boot fw. Nice, I like this! Just some style details below. > Also make a trivial change in a error log. > > Signed-off-by: Ava

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-25 Thread Bjorn Andersson
On Mon 22 May 06:26 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > On 5/22/2017 4:07 PM, Sricharan R wrote: > > Hi, > > > > On 5/22/2017 3:03 PM, Dwivedi, Avaneesh Kumar (avani) wrote: > > > > > > On 5/20/2017 8:25 AM, Sricharan R wrote: > > > > Hi Bjorn/Avaneesh, > > > > > > > > On 5/16/201

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-22 Thread Dwivedi, Avaneesh Kumar (avani)
On 5/22/2017 4:07 PM, Sricharan R wrote: Hi, On 5/22/2017 3:03 PM, Dwivedi, Avaneesh Kumar (avani) wrote: On 5/20/2017 8:25 AM, Sricharan R wrote: Hi Bjorn/Avaneesh, On 5/16/2017 11:32 PM, Avaneesh Kumar Dwivedi wrote: This patch refactor code to first load all firmware blobs and then upd

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-22 Thread Sricharan R
Hi, On 5/22/2017 3:03 PM, Dwivedi, Avaneesh Kumar (avani) wrote: > > > On 5/20/2017 8:25 AM, Sricharan R wrote: >> Hi Bjorn/Avaneesh, >> >> On 5/16/2017 11:32 PM, Avaneesh Kumar Dwivedi wrote: >>> This patch refactor code to first load all firmware blobs >>> and then update modem proc to authent

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-22 Thread Dwivedi, Avaneesh Kumar (avani)
On 5/20/2017 8:25 AM, Sricharan R wrote: Hi Bjorn/Avaneesh, On 5/16/2017 11:32 PM, Avaneesh Kumar Dwivedi wrote: This patch refactor code to first load all firmware blobs and then update modem proc to authenticate and boot fw. Also make a trivial change in a error log. Signed-off-by: Avanees

Re: [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-19 Thread Sricharan R
Hi Bjorn/Avaneesh, On 5/16/2017 11:32 PM, Avaneesh Kumar Dwivedi wrote: > This patch refactor code to first load all firmware blobs > and then update modem proc to authenticate and boot fw. > Also make a trivial change in a error log. > > Signed-off-by: Avaneesh Kumar Dwivedi > --- > drivers/re

[RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-16 Thread Avaneesh Kumar Dwivedi
This patch refactor code to first load all firmware blobs and then update modem proc to authenticate and boot fw. Also make a trivial change in a error log. Signed-off-by: Avaneesh Kumar Dwivedi --- drivers/remoteproc/qcom_q6v5_pil.c | 25 - 1 file changed, 12 insertions(

[PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence

2017-05-15 Thread Avaneesh Kumar Dwivedi
This patch refactor code to first load all firmware blobs and then update modem proc to authenticate and boot fw. Also make a trivial change in a error log. Signed-off-by: Avaneesh Kumar Dwivedi --- drivers/remoteproc/qcom_q6v5_pil.c | 25 - 1 file changed, 12 insertions(