Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, On Thu, 17 Dec 2015 15:18:46 +0530 Archit Taneja wrote: > > > > > Note that you could put the oobfree area at the end of the OOB area, > > since this 10-10-10-16-10 representation is already a virtual > > representation of the OOB area (ECC bytes are actually interleaved with > >

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, On Thu, 17 Dec 2015 15:18:46 +0530 Archit Taneja wrote: > > > > > Note that you could put the oobfree area at the end of the OOB area, > > since this 10-10-10-16-10 representation is already a virtual > > representation of the OOB area (ECC bytes are actually

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On 12/16/2015 07:48 PM, Boris Brezillon wrote: On Wed, 16 Dec 2015 17:27:48 +0530 Archit Taneja wrote: +/* + * NAND controller page layout info + * + * |---| |-| + * | xx...xx| | *xx...xx| + *

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On 12/16/2015 07:48 PM, Boris Brezillon wrote: On Wed, 16 Dec 2015 17:27:48 +0530 Archit Taneja wrote: +/* + * NAND controller page layout info + * + * |---| |-| + * | xx...xx| |

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On Wed, Dec 16, 2015 at 05:27:48PM +0530, Archit Taneja wrote: > On 12/16/2015 02:45 PM, Boris Brezillon wrote: > >On Wed, 19 Aug 2015 10:19:03 +0530 > >Archit Taneja wrote: > >>+ return mtd_device_parse_register(mtd, NULL, , NULL, 0); > > > > return mtd_device_parse_register(mtd, NULL,

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On Wed, 16 Dec 2015 17:27:48 +0530 Archit Taneja wrote: > >> +/* > >> + * NAND controller page layout info > >> + * > >> + * |---||-| > >> + * | xx...xx| | *xx...xx| > >> + * | DATA

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Boris, On 12/16/2015 02:45 PM, Boris Brezillon wrote: Hi Archit, Again, sorry for the late review. It's probably not exhaustive but points a few things that should be fixed. Thanks for the thorough review! Some comments below. On Wed, 19 Aug 2015 10:19:03 +0530 Archit Taneja wrote:

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, Again, sorry for the late review. It's probably not exhaustive but points a few things that should be fixed. On Wed, 19 Aug 2015 10:19:03 +0530 Archit Taneja wrote: > The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > MDM9x15 series. > > It exists as a sub block

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On Wed, Dec 16, 2015 at 05:27:48PM +0530, Archit Taneja wrote: > On 12/16/2015 02:45 PM, Boris Brezillon wrote: > >On Wed, 19 Aug 2015 10:19:03 +0530 > >Archit Taneja wrote: > >>+ return mtd_device_parse_register(mtd, NULL, , NULL, 0); > > > > return

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On Wed, 16 Dec 2015 17:27:48 +0530 Archit Taneja wrote: > >> +/* > >> + * NAND controller page layout info > >> + * > >> + * |---||-| > >> + * | xx...xx| | *xx...xx|

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Boris, On 12/16/2015 02:45 PM, Boris Brezillon wrote: Hi Archit, Again, sorry for the late review. It's probably not exhaustive but points a few things that should be fixed. Thanks for the thorough review! Some comments below. On Wed, 19 Aug 2015 10:19:03 +0530 Archit Taneja

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, Again, sorry for the late review. It's probably not exhaustive but points a few things that should be fixed. On Wed, 19 Aug 2015 10:19:03 +0530 Archit Taneja wrote: > The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > MDM9x15 series. > >

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi, On 10/06/2015 02:47 PM, Brian Norris wrote: Hi Archit, On Mon, Oct 05, 2015 at 12:21:54PM +0530, Archit Taneja wrote: On 10/02/2015 08:35 AM, Brian Norris wrote: On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x,

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, On Mon, Oct 05, 2015 at 12:21:54PM +0530, Archit Taneja wrote: > On 10/02/2015 08:35 AM, Brian Norris wrote: > >On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: > >>The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > >>MDM9x15 series. > >> > >>It exists

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi, On 10/06/2015 02:47 PM, Brian Norris wrote: Hi Archit, On Mon, Oct 05, 2015 at 12:21:54PM +0530, Archit Taneja wrote: On 10/02/2015 08:35 AM, Brian Norris wrote: On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x,

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, On Mon, Oct 05, 2015 at 12:21:54PM +0530, Archit Taneja wrote: > On 10/02/2015 08:35 AM, Brian Norris wrote: > >On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: > >>The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > >>MDM9x15 series. > >> > >>It exists

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Brian, Thanks for the review. On 10/02/2015 08:35 AM, Brian Norris wrote: Hi Archit, On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Brian, Thanks for the review. On 10/02/2015 08:35 AM, Brian Norris wrote: Hi Archit, On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

One more nit noticed by my build tests: On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: [...] > +static int qcom_nandc_ecc_init(struct qcom_nandc_data *this) > +{ > + struct mtd_info *mtd = >mtd; > + struct nand_chip *chip = >chip; > + struct nand_ecc_ctrl *ecc =

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

One more nit noticed by my build tests: On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: [...] > +static int qcom_nandc_ecc_init(struct qcom_nandc_data *this) > +{ > + struct mtd_info *mtd = >mtd; > + struct nand_chip *chip = >chip; > + struct nand_ecc_ctrl *ecc =

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: > The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > MDM9x15 series. > > It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) > and QPIC (Qualcomm Parallel Interface Controller). These

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

Hi Archit, On Wed, Aug 19, 2015 at 10:19:03AM +0530, Archit Taneja wrote: > The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > MDM9x15 series. > > It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) > and QPIC (Qualcomm Parallel Interface Controller). These

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On 8/27/2015 5:07 AM, Stephen Boyd wrote: On 08/19, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) and QPIC (Qualcomm Parallel Interface Controller). These IPs

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On 8/27/2015 5:07 AM, Stephen Boyd wrote: On 08/19, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) and QPIC (Qualcomm Parallel Interface Controller). These IPs

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On 08/19, Archit Taneja wrote: > The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, > MDM9x15 series. > > It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) > and QPIC (Qualcomm Parallel Interface Controller). These IPs provide a > broader interface for

Re: [PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

On 08/19, Archit Taneja wrote: The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) and QPIC (Qualcomm Parallel Interface Controller). These IPs provide a broader interface for external

[PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) and QPIC (Qualcomm Parallel Interface Controller). These IPs provide a broader interface for external slow peripheral devices such as LCD and

[PATCH v4 2/5] mtd: nand: Qualcomm NAND controller driver

The Qualcomm NAND controller is found in SoCs like IPQ806x, MSM7xx, MDM9x15 series. It exists as a sub block inside the IPs EBI2 (External Bus Interface 2) and QPIC (Qualcomm Parallel Interface Controller). These IPs provide a broader interface for external slow peripheral devices such as LCD and