>> >Sorry, this reply doesn't answer my question. I'm not asking about
>> >bp->speed and bp->duplex. I'm asking:
>> >1) why you are initialising bp->phy_interface here
>> >2) you to consider the impact that has on the mac_config() implementation
>> > you are proposing
>> > because I think it's
On Mon, Jun 24, 2019 at 10:14:41AM +, Parshuram Raju Thombare wrote:
> >> >I still don't think this makes much sense, splitting the interface
> >> > configuration between here and below.
> >> Do you mean splitting mac_config in two *_configure functions ?
> >> This was done as per Andrew's
>> >I still don't think this makes much sense, splitting the interface
>> > configuration between here and below.
>> Do you mean splitting mac_config in two *_configure functions ?
>> This was done as per Andrew's suggestion to make code mode readable
>> and easy to manage by splitting MAC
On Mon, Jun 24, 2019 at 06:35:44AM +, Parshuram Raju Thombare wrote:
>
> >> + if (change_interface) {
> >> + if (bp->phy_interface == PHY_INTERFACE_MODE_SGMII) {
> >> + gem_writel(bp, NCFGR, ~GEM_BIT(SGMIIEN) &
> >> + ~GEM_BIT(PCSSEL) &
>
>> +if (change_interface) {
>> +if (bp->phy_interface == PHY_INTERFACE_MODE_SGMII) {
>> +gem_writel(bp, NCFGR, ~GEM_BIT(SGMIIEN) &
>> + ~GEM_BIT(PCSSEL) &
>> + gem_readl(bp, NCFGR));
>> +
On Sun, Jun 23, 2019 at 10:23:01AM +0100, Parshuram Thombare wrote:
> This patch add support for SGMII interface) and
> 2.5Gbps MAC in Cadence ethernet controller driver.
>
> Signed-off-by: Parshuram Thombare
> ---
> drivers/net/ethernet/cadence/macb.h | 54
>
This patch add support for SGMII interface) and
2.5Gbps MAC in Cadence ethernet controller driver.
Signed-off-by: Parshuram Thombare
---
drivers/net/ethernet/cadence/macb.h | 54
drivers/net/ethernet/cadence/macb_main.c | 80 +---
2 files changed, 112
7 matches
Mail list logo
