Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

Hi Andy, On 04/04/2017 06:23 AM, Andy Shevchenko wrote: On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan wrote: +static inline int is_gcr_valid(u32 offset) Pointer to ipcdev should be a parameter to this function. But ipcdev is a static variable,

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

Hi Andy, On 04/04/2017 06:23 AM, Andy Shevchenko wrote: On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan wrote: +static inline int is_gcr_valid(u32 offset) Pointer to ipcdev should be a parameter to this function. But ipcdev is a static variable, visible across this

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan wrote: >>> +static inline int is_gcr_valid(u32 offset) >> >> Pointer to ipcdev should be a parameter to this function. > > But ipcdev is a static variable, visible across this file. So there is > no point

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan wrote: >>> +static inline int is_gcr_valid(u32 offset) >> >> Pointer to ipcdev should be a parameter to this function. > > But ipcdev is a static variable, visible across this file. So there is > no point in passing it as

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

Hi Andy, Thanks for your comments. On Sun, Apr 2, 2017 at 6:58 AM, Andy Shevchenko wrote: > On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan > wrote: >> This patch adds API's to read/write/update PMC GC registers.

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

Hi Andy, Thanks for your comments. On Sun, Apr 2, 2017 at 6:58 AM, Andy Shevchenko wrote: > On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan > wrote: >> This patch adds API's to read/write/update PMC GC registers. >> PMC dependent devices like iTCO_WDT, Telemetry has requirement > >

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan wrote: > This patch adds API's to read/write/update PMC GC registers. > PMC dependent devices like iTCO_WDT, Telemetry has requirement iTCO_wdt > to acces GCR registers. These API's can be

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan wrote: > This patch adds API's to read/write/update PMC GC registers. > PMC dependent devices like iTCO_WDT, Telemetry has requirement iTCO_wdt > to acces GCR registers. These API's can be used for this > purpose. > ---

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's (fwd)

tmp has type u32 and thus will not be < 0 julia -- Forwarded message -- Date: Sun, 2 Apr 2017 14:26:03 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v4 2/5] platform/x86: intel_p

Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's (fwd)

tmp has type u32 and thus will not be < 0 julia -- Forwarded message -- Date: Sun, 2 Apr 2017 14:26:03 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's In-Re

[PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

This patch adds API's to read/write/update PMC GC registers. PMC dependent devices like iTCO_WDT, Telemetry has requirement to acces GCR registers. These API's can be used for this purpose. Signed-off-by: Kuppuswamy Sathyanarayanan ---

[PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's

This patch adds API's to read/write/update PMC GC registers. PMC dependent devices like iTCO_WDT, Telemetry has requirement to acces GCR registers. These API's can be used for this purpose. Signed-off-by: Kuppuswamy Sathyanarayanan --- arch/x86/include/asm/intel_pmc_ipc.h | 21