Re: [PATCH v4 2/6] crypto: Use memzero_explicit() for clearing state

2020-10-26 Thread Ard Biesheuvel
On Sun, 25 Oct 2020 at 15:31, Arvind Sankar wrote: > > Without the barrier_data() inside memzero_explicit(), the compiler may > optimize away the state-clearing if it can tell that the state is not > used afterwards. > > Signed-off-by: Arvind Sankar Acked-by: Ard Biesheuvel I agree with Eric t

[PATCH v4 2/6] crypto: Use memzero_explicit() for clearing state

2020-10-25 Thread Arvind Sankar
Without the barrier_data() inside memzero_explicit(), the compiler may optimize away the state-clearing if it can tell that the state is not used afterwards. Signed-off-by: Arvind Sankar --- arch/arm64/crypto/ghash-ce-glue.c | 2 +- arch/arm64/crypto/poly1305-glue.c | 2 +- arch/arm64/crypto/sha