Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-04-09 Thread Thomas Zimmermann
Hi Am 09.04.21 um 15:50 schrieb Kevin Tang: > +static int __init sprd_drm_init(void) > +{ > +     int ret; I think ret should just go away. Like this? "return platform_register_drivers(sprd_drm_drivers, ARRAY_SIZE(sprd_drm_drivers));" Sure. Best regards Thomas if so, i

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-04-08 Thread Thomas Zimmermann
Hi, I have just a few nits below plus the points that others made. Am 22.02.21 um 14:28 schrieb Kevin Tang: Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-03-24 Thread Maxime Ripard
Hi On Mon, Feb 22, 2021 at 09:28:18PM +0800, Kevin Tang wrote: > Adds drm support for the Unisoc's display subsystem. > > This is drm kms driver, this driver provides support for the > application framework in Android, Yocto and more. > > Application framework can access Unisoc's display interne

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-02-22 Thread Orson Zhai
On Mon, Feb 22, 2021 at 9:28 PM Kevin Tang wrote: > > Adds drm support for the Unisoc's display subsystem. > > This is drm kms driver, this driver provides support for the > application framework in Android, Yocto and more. > > Application framework can access Unisoc's display internel > periphera

[PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-02-22 Thread Kevin Tang
Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by modetest (DRM/KMS te