Re: [PATCH v4 2/6] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper

2016-03-08 Thread Benson Leung
Thanks Tomeu! Small nit below, other wise looks good to me. On Tue, Mar 8, 2016 at 2:35 AM, Tomeu Vizoso wrote: > So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate > code when checking for errors from the EC side. > > Signed-off-by: Tomeu Vizoso

Re: [PATCH v4 2/6] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper

2016-03-08 Thread Benson Leung
Thanks Tomeu! Small nit below, other wise looks good to me. On Tue, Mar 8, 2016 at 2:35 AM, Tomeu Vizoso wrote: > So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate > code when checking for errors from the EC side. > > Signed-off-by: Tomeu Vizoso > --- > > Changes in v4: None

[PATCH v4 2/6] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper

2016-03-08 Thread Tomeu Vizoso
So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate code when checking for errors from the EC side. Signed-off-by: Tomeu Vizoso --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_proto.c | 14

[PATCH v4 2/6] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper

2016-03-08 Thread Tomeu Vizoso
So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate code when checking for errors from the EC side. Signed-off-by: Tomeu Vizoso --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_proto.c | 14 ++