Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-03-04 Thread Dan Murphy
Pavel On 3/2/19 5:07 PM, Pavel Machek wrote: > Hi! > >> I just want to follow up here and let you know that I have not abandoned >> this. >> I am trying to rework and fix up the ti lmu binding as asked by Pavel. Its >> proving >> to be a bit of a challenge based on looking forward to what will

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-03-02 Thread Pavel Machek
Hi! > I just want to follow up here and let you know that I have not abandoned this. > I am trying to rework and fix up the ti lmu binding as asked by Pavel. Its > proving > to be a bit of a challenge based on looking forward to what will be the > implementation. > > I also did go offline and

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-30 Thread Dan Murphy
All On 10/26/2018 03:37 AM, Pavel Machek wrote: > Hi! > >>> Do you have an opinion on this? >> >> This is this problem with the Device Tree's scope of responsibility. >> It is defined as a means for "describing the hardware", but often >> this rule is abused by the properties that fall into "conf

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-26 Thread Pavel Machek
Hi! > > Do you have an opinion on this? > > This is this problem with the Device Tree's scope of responsibility. > It is defined as a means for "describing the hardware", but often > this rule is abused by the properties that fall into "configuration" > category. E.g. default-state, retain-state-

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-26 Thread Pavel Machek
Hi! > > +Optional child properties: > > + - runtime-ramp-up-msec: Current ramping from one brightness > > level to > > + the a higher brightness level. > > + Range from 2048 us - 117.44 s > This is this problem

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-25 Thread Rob Herring
On Thu, Oct 25, 2018 at 08:27:18PM +0200, Jacek Anaszewski wrote: > On 10/25/2018 08:07 PM, Dan Murphy wrote: > > Rob > > > > On 10/24/2018 09:54 AM, Rob Herring wrote: > >> On Wed, Oct 24, 2018 at 07:07:57AM -0500, Dan Murphy wrote: > >>> Pavel > >>> > >>> On 10/24/2018 04:04 AM, Pavel Machek wro

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-25 Thread Dan Murphy
Jacek On 10/25/2018 01:27 PM, Jacek Anaszewski wrote: > On 10/25/2018 08:07 PM, Dan Murphy wrote: >> Rob >> >> On 10/24/2018 09:54 AM, Rob Herring wrote: >>> On Wed, Oct 24, 2018 at 07:07:57AM -0500, Dan Murphy wrote: Pavel On 10/24/2018 04:04 AM, Pavel Machek wrote: > Hi! >

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-25 Thread Jacek Anaszewski
On 10/25/2018 08:07 PM, Dan Murphy wrote: > Rob > > On 10/24/2018 09:54 AM, Rob Herring wrote: >> On Wed, Oct 24, 2018 at 07:07:57AM -0500, Dan Murphy wrote: >>> Pavel >>> >>> On 10/24/2018 04:04 AM, Pavel Machek wrote: Hi! > The LM3697 is a single function LED driver. The single fun

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-25 Thread Dan Murphy
Rob On 10/24/2018 09:54 AM, Rob Herring wrote: > On Wed, Oct 24, 2018 at 07:07:57AM -0500, Dan Murphy wrote: >> Pavel >> >> On 10/24/2018 04:04 AM, Pavel Machek wrote: >>> Hi! >>> The LM3697 is a single function LED driver. The single function LED driver needs to reside in the LED direct

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-25 Thread Dan Murphy
Rob Thanks On 10/24/2018 09:49 AM, Rob Herring wrote: > On Tue, Oct 23, 2018 at 12:06:18PM -0500, Dan Murphy wrote: >> The LM3697 is a single function LED driver. The single function LED >> driver needs to reside in the LED directory as a dedicated LED driver >> and not as a MFD device. The de

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-24 Thread Rob Herring
On Wed, Oct 24, 2018 at 07:07:57AM -0500, Dan Murphy wrote: > Pavel > > On 10/24/2018 04:04 AM, Pavel Machek wrote: > > Hi! > > > >> The LM3697 is a single function LED driver. The single function LED > >> driver needs to reside in the LED directory as a dedicated LED driver > >> and not as a MFD

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-24 Thread Rob Herring
On Tue, Oct 23, 2018 at 12:06:18PM -0500, Dan Murphy wrote: > The LM3697 is a single function LED driver. The single function LED > driver needs to reside in the LED directory as a dedicated LED driver > and not as a MFD device. The device does have common brightness and ramp > features and those

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-24 Thread Pavel Machek
Hi! > >> The LM3697 is a single function LED driver. The single function LED > >> driver needs to reside in the LED directory as a dedicated LED driver > >> and not as a MFD device. The device does have common brightness and ramp > > > > So it is single function LED driver. That does not mean it

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-24 Thread Dan Murphy
Pavel On 10/24/2018 04:04 AM, Pavel Machek wrote: > Hi! > >> The LM3697 is a single function LED driver. The single function LED >> driver needs to reside in the LED directory as a dedicated LED driver >> and not as a MFD device. The device does have common brightness and ramp > > So it is sing

Re: [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-24 Thread Pavel Machek
Hi! > The LM3697 is a single function LED driver. The single function LED > driver needs to reside in the LED directory as a dedicated LED driver > and not as a MFD device. The device does have common brightness and ramp So it is single function LED driver. That does not mean it can not share bi

[PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2018-10-23 Thread Dan Murphy
The LM3697 is a single function LED driver. The single function LED driver needs to reside in the LED directory as a dedicated LED driver and not as a MFD device. The device does have common brightness and ramp features and those can be accomodated by a TI LMU framework. The LM3697 dt binding nee