Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On 4/13/2018 2:08 AM, Stephen Boyd wrote: > Quoting Manu Gautam (2018-04-11 08:37:38) >>> I ask because it may be easier to never expose these clks in Linux, hit >>> the enable bits in the branches during clk driver probe, and then act >>> like they never exist because we don't really use

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On 4/13/2018 2:08 AM, Stephen Boyd wrote: > Quoting Manu Gautam (2018-04-11 08:37:38) >>> I ask because it may be easier to never expose these clks in Linux, hit >>> the enable bits in the branches during clk driver probe, and then act >>> like they never exist because we don't really use

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Quoting Manu Gautam (2018-04-11 08:37:38) > > > > I ask because it may be easier to never expose these clks in Linux, hit > > the enable bits in the branches during clk driver probe, and then act > > like they never exist because we don't really use them. > This sounds better idea. Let me check if

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Quoting Manu Gautam (2018-04-11 08:37:38) > > > > I ask because it may be easier to never expose these clks in Linux, hit > > the enable bits in the branches during clk driver probe, and then act > > like they never exist because we don't really use them. > This sounds better idea. Let me check if

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On 4/11/2018 12:02 AM, Stephen Boyd wrote: > Quoting Doug Anderson (2018-04-10 08:05:27) >> On Mon, Apr 9, 2018 at 11:36 PM, Manu Gautam wrote: >>> On 3/30/2018 2:24 AM, Doug Anderson wrote: Oh! This is what you did in the previous version of the patch, then

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On 4/11/2018 12:02 AM, Stephen Boyd wrote: > Quoting Doug Anderson (2018-04-10 08:05:27) >> On Mon, Apr 9, 2018 at 11:36 PM, Manu Gautam wrote: >>> On 3/30/2018 2:24 AM, Doug Anderson wrote: Oh! This is what you did in the previous version of the patch, then you said:

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Quoting Doug Anderson (2018-04-10 08:05:27) > On Mon, Apr 9, 2018 at 11:36 PM, Manu Gautam wrote: > > On 3/30/2018 2:24 AM, Doug Anderson wrote: > >> Oh! This is what you did in the previous version of the patch, then you > >> said: > >> > >> "That is still needed as PHY

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Quoting Doug Anderson (2018-04-10 08:05:27) > On Mon, Apr 9, 2018 at 11:36 PM, Manu Gautam wrote: > > On 3/30/2018 2:24 AM, Doug Anderson wrote: > >> Oh! This is what you did in the previous version of the patch, then you > >> said: > >> > >> "That is still needed as PHY might take some time to

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Mon, Apr 9, 2018 at 11:36 PM, Manu Gautam wrote: > Hi, > > > On 3/30/2018 2:24 AM, Doug Anderson wrote: >> Hi, >> >> On Thu, Mar 29, 2018 at 11:44 AM, Doug Anderson >> wrote: >>> Hi, >>> >>> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Mon, Apr 9, 2018 at 11:36 PM, Manu Gautam wrote: > Hi, > > > On 3/30/2018 2:24 AM, Doug Anderson wrote: >> Hi, >> >> On Thu, Mar 29, 2018 at 11:44 AM, Doug Anderson >> wrote: >>> Hi, >>> >>> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: QMP PHY for USB/PCIE requires pipe_clk

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On 3/30/2018 2:24 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 29, 2018 at 11:44 AM, Doug Anderson wrote: >> Hi, >> >> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: >>> QMP PHY for USB/PCIE requires pipe_clk for locking of >>> retime

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On 3/30/2018 2:24 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 29, 2018 at 11:44 AM, Doug Anderson wrote: >> Hi, >> >> On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: >>> QMP PHY for USB/PCIE requires pipe_clk for locking of >>> retime buffers at the pipe interface. Driver checks for

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Thu, Mar 29, 2018 at 11:44 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: >> QMP PHY for USB/PCIE requires pipe_clk for locking of >> retime buffers at the pipe interface. Driver checks for >>

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Thu, Mar 29, 2018 at 11:44 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: >> QMP PHY for USB/PCIE requires pipe_clk for locking of >> retime buffers at the pipe interface. Driver checks for >> PHY_STATUS without enabling pipe_clk due to which >>

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: > QMP PHY for USB/PCIE requires pipe_clk for locking of > retime buffers at the pipe interface. Driver checks for > PHY_STATUS without enabling pipe_clk due to which > phy_init() fails with initialization timeout. >

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi, On Thu, Mar 29, 2018 at 4:04 AM, Manu Gautam wrote: > QMP PHY for USB/PCIE requires pipe_clk for locking of > retime buffers at the pipe interface. Driver checks for > PHY_STATUS without enabling pipe_clk due to which > phy_init() fails with initialization timeout. > Though pipe_clk is

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi Manu, On Thu, Mar 29, 2018 at 4:06 AM Manu Gautam wrote: > QMP PHY for USB/PCIE requires pipe_clk for locking of > retime buffers at the pipe interface. Driver checks for > PHY_STATUS without enabling pipe_clk due to which > phy_init() fails with initialization

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi Manu, On Thu, Mar 29, 2018 at 4:06 AM Manu Gautam wrote: > QMP PHY for USB/PCIE requires pipe_clk for locking of > retime buffers at the pipe interface. Driver checks for > PHY_STATUS without enabling pipe_clk due to which > phy_init() fails with initialization timeout. > Though pipe_clk is

[PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

QMP PHY for USB/PCIE requires pipe_clk for locking of retime buffers at the pipe interface. Driver checks for PHY_STATUS without enabling pipe_clk due to which phy_init() fails with initialization timeout. Though pipe_clk is output from PHY (after PLL is programmed during initialization sequence)

[PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

QMP PHY for USB/PCIE requires pipe_clk for locking of retime buffers at the pipe interface. Driver checks for PHY_STATUS without enabling pipe_clk due to which phy_init() fails with initialization timeout. Though pipe_clk is output from PHY (after PLL is programmed during initialization sequence)