Re: [PATCH v4 20/25] mm/filemap: Convert wait_on_page_bit to wait_on_folio_bit

2021-03-17 Thread Christoph Hellwig
> + if (FolioWriteback(folio) && > + wait_on_folio_bit_killable(folio, PG_writeback) < 0) > return VM_FAULT_RETRY; This really screams for a proper wait_on_page_writeback_killable helper rather than hardcoding the PG_* bit in a random file system. It also seems to have

[PATCH v4 20/25] mm/filemap: Convert wait_on_page_bit to wait_on_folio_bit

2021-03-04 Thread Matthew Wilcox (Oracle)
We must always wait on the folio, otherwise we won't be woken up. This commit shrinks the kernel by 695 bytes, mostly due to moving the page waitqueue lookup into wait_on_folio_bit_common(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/afs/write.c | 21