Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-08 Thread Dmitry Osipenko
08.04.2021 16:06, Thierry Reding пишет: > On Thu, Apr 08, 2021 at 02:25:19AM +0300, Dmitry Osipenko wrote: >> 08.04.2021 02:00, Sowjanya Komatineni пишет: >>> >>> On 4/7/21 3:57 PM, Sowjanya Komatineni wrote: On 4/7/21 2:36 PM, Dmitry Osipenko wrote: > 07.04.2021 04:25, Sowjanya Komat

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 02:25:19AM +0300, Dmitry Osipenko wrote: > 08.04.2021 02:00, Sowjanya Komatineni пишет: > > > > On 4/7/21 3:57 PM, Sowjanya Komatineni wrote: > >> > >> On 4/7/21 2:36 PM, Dmitry Osipenko wrote: > >>> 07.04.2021 04:25, Sowjanya Komatineni пишет: > +    if (!tegra->pdev-

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-07 Thread Dmitry Osipenko
08.04.2021 02:00, Sowjanya Komatineni пишет: > > On 4/7/21 3:57 PM, Sowjanya Komatineni wrote: >> >> On 4/7/21 2:36 PM, Dmitry Osipenko wrote: >>> 07.04.2021 04:25, Sowjanya Komatineni пишет: +    if (!tegra->pdev->dev.pm_domain) { +    ret = tegra_powergate_sequence_power_up(TEGRA_P

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-07 Thread Sowjanya Komatineni
On 4/7/21 3:57 PM, Sowjanya Komatineni wrote: On 4/7/21 2:36 PM, Dmitry Osipenko wrote: 07.04.2021 04:25, Sowjanya Komatineni пишет: +    if (!tegra->pdev->dev.pm_domain) { +    ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA, +    tegra->sata_clk, + 

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-07 Thread Sowjanya Komatineni
On 4/7/21 2:36 PM, Dmitry Osipenko wrote: 07.04.2021 04:25, Sowjanya Komatineni пишет: + if (!tegra->pdev->dev.pm_domain) { + ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA, + tegra->sata_clk, +

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-07 Thread Dmitry Osipenko
07.04.2021 04:25, Sowjanya Komatineni пишет: > + if (!tegra->pdev->dev.pm_domain) { > + ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA, > + tegra->sata_clk, > + tegr

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-07 Thread Thierry Reding
On Tue, Apr 06, 2021 at 06:25:31PM -0700, Sowjanya Komatineni wrote: > This patch adds support for AHCI-compliant Serial ATA controller > on Tegra186 SoC. > > Tegra186 does not have sata-oob reset. > Tegra186 SATA_NVOOB register filed COMMA_CNT position and width are > different compared to Tegra2

[PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-06 Thread Sowjanya Komatineni
This patch adds support for AHCI-compliant Serial ATA controller on Tegra186 SoC. Tegra186 does not have sata-oob reset. Tegra186 SATA_NVOOB register filed COMMA_CNT position and width are different compared to Tegra210 and prior. So, this patch adds a flag has_sata_oob_rst and tegra_ahci_regs to