RE: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Nava kishore Manne
; Rajan Vaja ; Jolly Shah > ; linux-f...@vger.kernel.org; open list:OPEN FIRMWARE > AND FLATTENED DEVICE TREE BINDINGS ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE ker...@lists.infradead.org>; linux-kernel ; > kishore m > Subject: Re: [PATCH v4 3/3] fpga manager: A

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Michal Simek
On 08. 04. 19 22:27, Alan Tull wrote: > On Mon, Apr 8, 2019 at 11:51 AM Moritz Fischer wrote: >> >> Hi Michal, >> >> On Mon, Apr 08, 2019 at 04:36:15PM +0200, Michal Simek wrote: >>> On 08. 04. 19 16:17, Alan Tull wrote: On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne wrote: > > Hi

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Alan Tull
On Mon, Apr 8, 2019 at 11:51 AM Moritz Fischer wrote: > > Hi Michal, > > On Mon, Apr 08, 2019 at 04:36:15PM +0200, Michal Simek wrote: > > On 08. 04. 19 16:17, Alan Tull wrote: > > > On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne > > > wrote: > > >> > > >> Hi Alan, > > >> > > >> Thanks for lo

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Moritz Fischer
Hi Michal, On Mon, Apr 08, 2019 at 04:36:15PM +0200, Michal Simek wrote: > On 08. 04. 19 16:17, Alan Tull wrote: > > On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne wrote: > >> > >> Hi Alan, > >> > >> Thanks for look into it and providing the ACK. > >> I got one minor comments from Moritz Fisch

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Michal Simek
On 08. 04. 19 16:17, Alan Tull wrote: > On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne wrote: >> >> Hi Alan, >> >> Thanks for look into it and providing the ACK. >> I got one minor comments from Moritz Fischer do you want me fix that issue >> now or I can fix it later as it’s a minor comment?

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Alan Tull
DEVICE > > TREE BINDINGS ; moderated list:ARM/FREESCALE > > IMX / MXC ARM ARCHITECTURE ; linux- > > kernel ; kishore m > > > > Subject: Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for > > Xilinx zynqmp > > > > On Tue, Apr 2, 2019 at 7

RE: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Nava kishore Manne
D DEVICE > TREE BINDINGS ; moderated list:ARM/FREESCALE > IMX / MXC ARM ARCHITECTURE ; linux- > kernel ; kishore m > > Subject: Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for > Xilinx zynqmp > > On Tue, Apr 2, 2019 at 7:32 AM Nava kishore Manne > wr

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-02 Thread Alan Tull
On Tue, Apr 2, 2019 at 7:32 AM Nava kishore Manne wrote: Hi Nava, Looks good. > > This patch adds FPGA Manager support for the Xilinx > ZynqMP chip. > > Signed-off-by: Nava kishore Manne Acked-by: Alan Tull > --- > Changes for v4: > -Updated the Fpga Mgr registrations call's

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-02 Thread Moritz Fischer
Hi Nava, looks mostly good to me. One minor nit below: On Tue, Apr 02, 2019 at 06:01:23PM +0530, Nava kishore Manne wrote: [..] > diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c > new file mode 100644 > index ..f6e35fe95adb > --- /dev/null > +++ b/drivers/fpga/zy

[PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-02 Thread Nava kishore Manne
This patch adds FPGA Manager support for the Xilinx ZynqMP chip. Signed-off-by: Nava kishore Manne --- Changes for v4: -Updated the Fpga Mgr registrations call's to 5.0 -Removed dma_set_mask_and_coherent() As the FW supports only 3