Re: [PATCH v4 3/3] fs: let filldir_t return bool instead of an error code

2019-01-31 Thread Darrick J. Wong
On Wed, Jan 23, 2019 at 04:07:59PM +0100, Jann Horn wrote: > On Mon, Jan 21, 2019 at 11:24 PM Dave Chinner wrote: > > On Mon, Jan 21, 2019 at 04:49:45PM +0100, Jann Horn wrote: > > > On Sun, Jan 20, 2019 at 11:41 PM Dave Chinner wrote: > > > > On Fri, Jan 18, 2019 at 05:14:40PM +0100, Jann Horn w

Re: [PATCH v4 3/3] fs: let filldir_t return bool instead of an error code

2019-01-23 Thread Jann Horn
On Mon, Jan 21, 2019 at 11:24 PM Dave Chinner wrote: > On Mon, Jan 21, 2019 at 04:49:45PM +0100, Jann Horn wrote: > > On Sun, Jan 20, 2019 at 11:41 PM Dave Chinner wrote: > > > On Fri, Jan 18, 2019 at 05:14:40PM +0100, Jann Horn wrote: > > > > As Al Viro pointed out, many filldir_t functions retu

Re: [PATCH v4 3/3] fs: let filldir_t return bool instead of an error code

2019-01-21 Thread Dave Chinner
On Mon, Jan 21, 2019 at 04:49:45PM +0100, Jann Horn wrote: > On Sun, Jan 20, 2019 at 11:41 PM Dave Chinner wrote: > > On Fri, Jan 18, 2019 at 05:14:40PM +0100, Jann Horn wrote: > > > As Al Viro pointed out, many filldir_t functions return error codes, but > > > all callers of filldir_t functions j

Re: [PATCH v4 3/3] fs: let filldir_t return bool instead of an error code

2019-01-21 Thread Jann Horn
On Sun, Jan 20, 2019 at 11:41 PM Dave Chinner wrote: > On Fri, Jan 18, 2019 at 05:14:40PM +0100, Jann Horn wrote: > > As Al Viro pointed out, many filldir_t functions return error codes, but > > all callers of filldir_t functions just check whether the return value is > > non-zero (to determine wh

Re: [PATCH v4 3/3] fs: let filldir_t return bool instead of an error code

2019-01-21 Thread Dave Chinner
On Fri, Jan 18, 2019 at 05:14:40PM +0100, Jann Horn wrote: > As Al Viro pointed out, many filldir_t functions return error codes, but > all callers of filldir_t functions just check whether the return value is > non-zero (to determine whether to continue reading the directory); more > precise error

[PATCH v4 3/3] fs: let filldir_t return bool instead of an error code

2019-01-18 Thread Jann Horn
As Al Viro pointed out, many filldir_t functions return error codes, but all callers of filldir_t functions just check whether the return value is non-zero (to determine whether to continue reading the directory); more precise errors have to be signalled via struct dir_context. Change all filldir_t