Re: [PATCH v4 3/3] i2c: mediatek: Add i2c support for MediaTek MT8183

2019-03-06 Thread Qii Wang
I am sorry to have missed some comment, and reply the mail again. On Wed, 2019-02-20 at 15:41 +0100, Matthias Brugger wrote: > > On 20/02/2019 13:33, Qii Wang wrote: > > Add i2c compatible for MT8183. Compare to MT2712 i2c controller, > > MT8183 has different registers, offsets and clock. > > >

Re: [PATCH v4 3/3] i2c: mediatek: Add i2c support for MediaTek MT8183

2019-02-21 Thread Qii Wang
On Wed, 2019-02-20 at 15:41 +0100, Matthias Brugger wrote: > > On 20/02/2019 13:33, Qii Wang wrote: > > Add i2c compatible for MT8183. Compare to MT2712 i2c controller, > > MT8183 has different registers, offsets and clock. > > > > Signed-off-by: Qii Wang > > So you introduce arb clock, ltiming

Re: [PATCH v4 3/3] i2c: mediatek: Add i2c support for MediaTek MT8183

2019-02-20 Thread Matthias Brugger
On 20/02/2019 13:33, Qii Wang wrote: > Add i2c compatible for MT8183. Compare to MT2712 i2c controller, > MT8183 has different registers, offsets and clock. > > Signed-off-by: Qii Wang So you introduce arb clock, ltiming (what is this exactly) and the new SoC in one commit. I'd prefer to spli

[PATCH v4 3/3] i2c: mediatek: Add i2c support for MediaTek MT8183

2019-02-20 Thread Qii Wang
Add i2c compatible for MT8183. Compare to MT2712 i2c controller, MT8183 has different registers, offsets and clock. Signed-off-by: Qii Wang --- drivers/i2c/busses/i2c-mt65xx.c | 89 --- 1 file changed, 84 insertions(+), 5 deletions(-) diff --git a/drivers/i