Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-07 Thread Quentin Schulz
On 04/09/2016 16:35, Jonathan Cameron wrote: > On 01/09/16 15:05, Quentin Schulz wrote: >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. This patch adds the ADC driver which is >> based on the MFD for the same SoCs ADC. >> >> This also reg

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-07 Thread Quentin Schulz
On 04/09/2016 18:12, Peter Meerwald-Stadler wrote: > >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. This patch adds the ADC driver which is >> based on the MFD for the same SoCs ADC. > > nitpicking ahead > [...] >> diff --git a/drive

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Jonathan Cameron
On 05/09/16 07:29, Quentin Schulz wrote: > On 04/09/2016 16:35, Jonathan Cameron wrote: >> On 01/09/16 15:05, Quentin Schulz wrote: >>> The Allwinner SoCs all have an ADC that can also act as a touchscreen >>> controller and a thermal sensor. This patch adds the ADC driver which is >>> based on the

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Joshua Clayton
On Monday, September 05, 2016 09:11:47 AM Quentin Schulz wrote: > On 05/09/2016 09:07, Maxime Ripard wrote: > > Hi, > > > > Nitpicks ahead. > > > > On Thu, Sep 01, 2016 at 04:05:05PM +0200, Quentin Schulz wrote: > >> + info->soc_specific = (struct soc_specific > >> *)platform_get_device_id(pdev

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Peter Meerwald-Stadler
> +{ > +return SUN6I_GPADC_CTRL1_ADC_CHAN_SELECT(chan); > +} > + > +struct soc_specific { > +const int temp_offset; > >>> > >>> wondering why you constify every member? > >>> > >> > >> Because they're supposed to be fixed values? It won't

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Quentin Schulz
On 05/09/2016 10:07, Peter Meerwald-Stadler wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. This patch adds the ADC driver which is based on the MFD for the same SoCs ADC. >>> >>> nitpicking ahead > >> [...] + >>>

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Peter Meerwald-Stadler
> >> The Allwinner SoCs all have an ADC that can also act as a touchscreen > >> controller and a thermal sensor. This patch adds the ADC driver which is > >> based on the MFD for the same SoCs ADC. > > > > nitpicking ahead > [...] > >> + > >> +const unsigned int sun4i_gpadc_chan_select(unsigned

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Quentin Schulz
On 05/09/2016 09:07, Maxime Ripard wrote: > Hi, > > Nitpicks ahead. > > On Thu, Sep 01, 2016 at 04:05:05PM +0200, Quentin Schulz wrote: >> +info->soc_specific = (struct soc_specific >> *)platform_get_device_id(pdev)->driver_data; > > This line is still rather long. How about calling the fie

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-05 Thread Maxime Ripard
Hi, Nitpicks ahead. On Thu, Sep 01, 2016 at 04:05:05PM +0200, Quentin Schulz wrote: > + info->soc_specific = (struct soc_specific > *)platform_get_device_id(pdev)->driver_data; This line is still rather long. How about calling the field "data" and the structure gpadc_data? > + > + tzd

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-04 Thread Quentin Schulz
On 04/09/2016 18:12, Peter Meerwald-Stadler wrote: > >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. This patch adds the ADC driver which is >> based on the MFD for the same SoCs ADC. > > nitpicking ahead > [...] >> diff --git a/drive

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-04 Thread Quentin Schulz
On 04/09/2016 16:35, Jonathan Cameron wrote: > On 01/09/16 15:05, Quentin Schulz wrote: >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. This patch adds the ADC driver which is >> based on the MFD for the same SoCs ADC. >> >> This also reg

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-04 Thread Peter Meerwald-Stadler
> The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. nitpicking ahead > This also registers the thermal adc channel in the iio map array so > iio_hwmon could u

Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-04 Thread Jonathan Cameron
On 01/09/16 15:05, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc channel in the iio map array

[PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

2016-09-01 Thread Quentin Schulz
The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. This patch adds the ADC driver which is based on the MFD for the same SoCs ADC. This also registers the thermal adc channel in the iio map array so iio_hwmon could use it without modifying the De