Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Kirill A. Shutemov
On Thu, Sep 19, 2019 at 03:41:43PM +, Catalin Marinas wrote: > On Thu, Sep 19, 2019 at 06:00:07PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 18, 2019 at 07:00:30PM +0100, Catalin Marinas wrote: > > > On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > > > > On Wed, Sep 1

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Catalin Marinas
On Thu, Sep 19, 2019 at 06:00:07PM +0300, Kirill A. Shutemov wrote: > On Wed, Sep 18, 2019 at 07:00:30PM +0100, Catalin Marinas wrote: > > On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > > > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > > > @@ -2152,20 +2163,34 @

RE: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Justin He (Arm Technology China)
r > ; Andrew Morton ; > Jérôme Glisse ; Ralph Campbell > ; Kaly Xin (Arm Technology China) > > Subject: Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is > cleared > > On Thu, Sep 19, 2019 at 10:16:34AM +0800, Jia He wrote: > > Hi Kirill > > > >

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Kirill A. Shutemov
On Wed, Sep 18, 2019 at 07:00:30PM +0100, Catalin Marinas wrote: > On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > > @@ -2152,20 +2163,34 @@ static inline void cow_user_page(struct page > > > *dst, struct page *src

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Kirill A. Shutemov
On Thu, Sep 19, 2019 at 10:16:34AM +0800, Jia He wrote: > Hi Kirill > > [On behalf of justin...@arm.com because some mails are filted...] > > On 2019/9/18 22:00, Kirill A. Shutemov wrote: > > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > > When we tested pmdk unit test [1] vmmalloc_

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Jia He
Hi Kirill [On behalf of justin...@arm.com because some mails are filted...] On 2019/9/18 22:00, Kirill A. Shutemov wrote: On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: When we tested pmdk unit test [1] vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in __copy_fr

RE: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Justin He (Arm Technology China)
hejia...@gmail.com; Kaly Xin (Arm Technology China) > ; Justin He (Arm Technology China) > > Subject: Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF > is cleared > > Hi Jia, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread kbuild test robot
Hi Jia, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190917] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jia-He/fix

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Catalin Marinas
On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > @@ -2152,20 +2163,34 @@ static inline void cow_user_page(struct page *dst, > > struct page *src, unsigned lo > > */ > > if (unlikely(!src)) { > > v

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Kirill A. Shutemov
On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > When we tested pmdk unit test [1] vmmalloc_fork TEST1 in arm64 guest, there > will be a double page fault in __copy_from_user_inatomic of cow_user_page. > > Below call trace is from arm64 do_page_fault for debugging purpose > [ 110.016195]

[PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Jia He
When we tested pmdk unit test [1] vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in __copy_from_user_inatomic of cow_user_page. Below call trace is from arm64 do_page_fault for debugging purpose [ 110.016195] Call trace: [ 110.016826] do_page_fault+0x5a4/0x690 [ 110.0178