Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper

2021-04-06 Thread Valentin Schneider
On 06/04/21 17:37, Dietmar Eggemann wrote: > On 01/04/2021 21:30, Valentin Schneider wrote: >> While at it, replace group_smaller_{min, max}_cpu_capacity() with >> comparisons of the source group's min/max capacity and the destination >> CPU's capacity. > > IMHO, you haven't mentioned why you

Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper

2021-04-06 Thread Dietmar Eggemann
On 01/04/2021 21:30, Valentin Schneider wrote: > During load-balance, groups classified as group_misfit_task are filtered > out if they do not pass > > group_smaller_max_cpu_capacity(, ); > > which itself employs fits_capacity() to compare the sgc->max_capacity of > both groups. > > Due to

Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper

2021-04-02 Thread Vincent Guittot
On Thu, 1 Apr 2021 at 21:30, Valentin Schneider wrote: > > During load-balance, groups classified as group_misfit_task are filtered > out if they do not pass > > group_smaller_max_cpu_capacity(, ); > > which itself employs fits_capacity() to compare the sgc->max_capacity of > both groups. > >

[PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper

2021-04-01 Thread Valentin Schneider
During load-balance, groups classified as group_misfit_task are filtered out if they do not pass group_smaller_max_cpu_capacity(, ); which itself employs fits_capacity() to compare the sgc->max_capacity of both groups. Due to the underlying margin, fits_capacity(X, 1024) will return false for